Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] - {0.4.2}: add zero address in oracle.sol #1135

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[R4R] - {0.4.2}: add zero address in oracle.sol #1135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
284d037
add zero address check on oracle.sol
Ethanncnm Jun 27, 2023
eda269e
fix comments
Ethanncnm Jun 27, 2023
ea2cc64
Merge remote-tracking branch 'origin/develop' into ethan/mnt-33
Ethanncnm Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions l2geth/contracts/checkpointoracle/contract/oracle.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ contract CheckpointOracle {
*/
constructor(address[] memory _adminlist, uint _sectionSize, uint _processConfirms, uint _threshold) public {
for (uint i = 0; i < _adminlist.length; i++) {
require(_adminlist[i] != address(0),"admin list cant contains 0 address");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin list cant contains 0 address -> admin list can't contain 0 address

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

admins[_adminlist[i]] = true;
adminList.push(_adminlist[i]);
}
Expand Down