Skip to content

Commit

Permalink
move signup/secret to backend/secret
Browse files Browse the repository at this point in the history
  • Loading branch information
ianic committed Nov 21, 2021
1 parent 6ca4f62 commit bcc3557
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 13 deletions.
2 changes: 1 addition & 1 deletion backend/api/signup/signup.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/aws/aws-sdk-go-v2/service/ses"
"github.com/aws/aws-sdk-go-v2/service/ses/types"
"github.com/mantil-io/mantil.go"
"github.com/mantil-io/mantil/backend/secret"
"github.com/mantil-io/mantil/signup"
"github.com/mantil-io/mantil/signup/secret"
"github.com/mantil-io/mantil/texts"
)

Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ package secret_test
import (
"testing"

"github.com/mantil-io/mantil/backend/secret"
cliSecret "github.com/mantil-io/mantil/cli/secret"
"github.com/mantil-io/mantil/signup"
"github.com/mantil-io/mantil/signup/secret"
"github.com/stretchr/testify/require"
)

Expand All @@ -19,7 +20,7 @@ func TestEncode(t *testing.T) {
t.Logf("token: %s", tkn)
require.NoError(t, err)

ut2, err := signup.Decode(tkn)
ut2, err := signup.Decode(tkn, cliSecret.SignupPublicKey)
require.NoError(t, err)
require.Equal(t, ut.ID, ut2.ID)
require.Equal(t, ut.Email, ut2.Email)
Expand Down
3 changes: 2 additions & 1 deletion backend/test/register_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"testing"

"github.com/gavv/httpexpect"
"github.com/mantil-io/mantil/cli/secret"
"github.com/mantil-io/mantil/domain"
"github.com/mantil-io/mantil/signup"
"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -35,7 +36,7 @@ func TestSignup(t *testing.T) {
Status(http.StatusOK).
Text().Raw()

tc, err := signup.Decode(jwt)
tc, err := signup.Decode(jwt, secret.SignupPublicKey)
require.NoError(t, err)

t.Logf("jwt: %s", jwt)
Expand Down
3 changes: 2 additions & 1 deletion cli/controller/report.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/manifoldco/promptui"
"github.com/mantil-io/mantil/backend/dto"
"github.com/mantil-io/mantil/cli/log"
"github.com/mantil-io/mantil/cli/secret"
"github.com/mantil-io/mantil/cli/ui"
"github.com/mantil-io/mantil/domain"
"github.com/mantil-io/mantil/signup"
Expand Down Expand Up @@ -71,7 +72,7 @@ func userID() (string, error) {
if err != nil {
return "", log.Wrap(err)
}
claims, err := signup.Decode(token)
claims, err := signup.Decode(token, secret.SignupPublicKey)
if err != nil {
return "", log.Wrap(err)
}
Expand Down
5 changes: 3 additions & 2 deletions cli/controller/signup.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/manifoldco/promptui"
"github.com/mantil-io/mantil/cli/log"
"github.com/mantil-io/mantil/cli/secret"
"github.com/mantil-io/mantil/cli/ui"
"github.com/mantil-io/mantil/domain"
"github.com/mantil-io/mantil/signup"
Expand Down Expand Up @@ -36,7 +37,7 @@ func Activate(id string) error {
if err := signupEndpoint.Call("activate", ar, &jwt); err != nil {
return log.Wrap(err)
}
claims, err := signup.Validate(jwt, machineID)
claims, err := signup.Validate(jwt, secret.SignupPublicKey, machineID)
if err != nil {
return log.Wrap(err)
}
Expand All @@ -55,7 +56,7 @@ func IsActivated() bool {
log.Error(err)
return false
}
claims, err := signup.Validate(jwt, domain.MachineID())
claims, err := signup.Validate(jwt, secret.SignupPublicKey, domain.MachineID())
if err != nil {
log.Error(err)
return false
Expand Down
3 changes: 3 additions & 0 deletions cli/secret/secret.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ var LogsPublisherCreds string
// nsc add user -n logs-listener --allow-sub '_INBOX.>' --deny-pub '*'
//go:embed logs-listener.creds
var LogsListenerCreds string

//go:embed signup_public_key
var SignupPublicKey string
File renamed without changes.
2 changes: 1 addition & 1 deletion end_to_end_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import (

"github.com/mantil-io/mantil.go/logs"
"github.com/mantil-io/mantil/aws"
"github.com/mantil-io/mantil/backend/secret"
"github.com/mantil-io/mantil/cli/controller/invoke"
"github.com/mantil-io/mantil/domain"
"github.com/mantil-io/mantil/kit/shell"
"github.com/mantil-io/mantil/signup/secret"
"github.com/stretchr/testify/require"
)

Expand Down
7 changes: 2 additions & 5 deletions signup/signup.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ import (
"github.com/mantil-io/mantil/kit/token"
)

//go:embed public_key
var publicKey string

// TokenClaims content of the user token
type TokenClaims struct {
ID string `json:"id,omitempty"`
Expand All @@ -25,14 +22,14 @@ type TokenClaims struct {

// Decode jwt token string to claims.
// Fails if jwt is not signed by proper private key.
func Decode(jwt string) (TokenClaims, error) {
func Decode(jwt, publicKey string) (TokenClaims, error) {
var ut TokenClaims
err := token.Decode(jwt, publicKey, &ut)
return ut, err
}

// Validate returns true if jwt is valid for that machine
func Validate(jwt, machineID string) (*TokenClaims, error) {
func Validate(jwt, publicKey, machineID string) (*TokenClaims, error) {
jwt = strings.TrimSpace(jwt)
var ut TokenClaims
err := token.Decode(jwt, publicKey, &ut)
Expand Down

0 comments on commit bcc3557

Please sign in to comment.