This repository was archived by the owner on Jan 21, 2025. It is now read-only.
Fix problem compiling Mantid in Debug on VS2022#70
Merged
martyngigg merged 2 commits intomainfrom Mar 24, 2022
Merged
Conversation
DannyHindson
force-pushed
the
AddSupportForVS2022
branch
from
badae04 to
9380c08
Compare
DannyHindson
changed the title
DannyHindson
changed the title
This resolves a problem generating a debug build of Mantid in VS2022 Fix based on approach taken by PyBind to similar issue
DannyHindson
force-pushed
the
AddSupportForVS2022
branch
from
9380c08 to
d35cde3
Compare
To allow debug build to work in VS2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a problem generating a debug build of Mantid in VS2022. The build failed with errors like:
Fix is based on similar problem PyBind were having:
pybind/pybind11#3497
The updated file also exists in build-scripts\extras\python\wrappython.h. Not sure if I should also update this?