Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created show-version-trailing-semicolon.rec and test-fuzzy-trailing-s… #2867

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Created show-version-trailing-semicolon.rec and test-fuzzy-trailing-s… #2867

merged 1 commit into from
Jan 8, 2025

Conversation

PavelShilin89
Copy link
Contributor

Type of Change:

  • Bug fix

Description of the Change:

  • Fixed an issue that occurred when executing SQL queries through the HTTP API with a trailing semicolon (;). The problem was related to incorrect handling of the trailing ; by the parser. The fix has been verified through testing.

Related Issue (provide the link):

@PavelShilin89 PavelShilin89 mentioned this pull request Dec 19, 2024
Closed
5 tasks
donhardman
donhardman approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@donhardman donhardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should test semicolon just in HTTP but I think it's okay to leave mysql also in case

@PavelShilin89 PavelShilin89 merged commit 430282c into master Jan 8, 2025
63 checks passed
@PavelShilin89 PavelShilin89 deleted the test/issue-415-trailing-semicolon branch January 8, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donhardman donhardman donhardman approved these changes

Assignees
No one assigned
Labels
done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PavelShilin89 @donhardman