-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover locale choice #66
Comments
It's more like an issue to be honest. But, i agree about user could choose cover locale. I will fix this bug and add a new option |
I've made PR #73 that will close this issue, you can try test it from development version. Installation with git + pip:
If you're installing mangadex-downloader from github releases, you can download the development version in here: The download files are available in "artifacts" section https://github.com/mansuf/mangadex-downloader/actions/runs/5212468729 The volume cover language now follow Also i added Example usage:
This will find volumes cover with Please note, the application can use main cover as replacement for volumes that didn't have cover for that language. You will notice warning like this
|
Hello there, Tested it out locally by checking out the branch (as I use the git clone variant). Running the following two commands with just
Gave me the English covers as requested. and
Gave me the Japanese covers as requested. As a third, I also tested it with
Which used Russian manga and covers. And then finally to be thorough I combined both
Which produced the Russian manga but with English covers as requested. Feature seems to work from all my tests, thank you for the great work. :) |
Fix volume cover locale is not consistent and add feature to change volume cover locale
The idea
We can now embed the covers from "Art" in the volumes by using
--use-volume-cover
which is amazing.However for example with "Rising of the SHield Hero" there are covers in like 10 different languages:
https://mangadex.org/title/0f237a5f-07ad-4e43-bbd9-2a320694434d/tate-no-yuusha-no-nariagari?tab=art
It seems to grab the first one it can find for every volume. Which is sometimes Russian, sometimes Japanese, etc.. It's a real mess honestly to see each volume do a lottery on which language it'll use for a cover.
It'd be a real great quality of life if in some way the user could choose the locale "en", "jp" or somehow to define which language the covers should prefer.
Why this feature should be added to the app ?
It would fix the somewhat messy multiple cover languages that we're currently getting when a manga has multiple language art covers.
The text was updated successfully, but these errors were encountered: