Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tableflip spinner #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

leifwalsh
Copy link

Description of new feature, or changes

Adds a spinner that looks like two characters flipping a table back and forth

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

People to notify

@leifwalsh
Copy link
Author

@manrajgrover need anything from me?

@manrajgrover
Copy link
Owner

@leifwalsh Thanks for working on this. Since this spinner is user contributed, I was thinking of creating a separate dictionary for user contributed spinners and combine them with cli-spinners before creating Enum. Can you make these changes and I can then review the code?

@leifwalsh
Copy link
Author

It's not clear what you're asking for here

@d-chris
Copy link

d-chris commented Jul 25, 2024

@leifwalsh Thanks for working on this. Since this spinner is user contributed, I was thinking of creating a separate dictionary for user contributed spinners and combine them with cli-spinners before creating Enum. Can you make these changes and I can then review the code?

@manrajgrover i tried to tackle this task, but for development with following restriction:

  • python ^3.8, would this be ok?
  • i got some issues using pylint executing some base64 code, so i removed it from tox.ini. is flake8 also an option?
  • nose is not longer maintained so i switched to pytest
  • I received some warnings related to setup.py running tox, and I don't have much experience with it. Would switching to poetry be a feasible option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants