-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update check for Unicode support #144
Open
norweeg
wants to merge
9
commits into
manrajgrover:master
Choose a base branch
from
norweeg:remove-terminal-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norweeg
force-pushed
the
remove-terminal-check
branch
from
August 4, 2020 16:06
0d582d7
to
6ae75b8
Compare
norweeg
force-pushed
the
remove-terminal-check
branch
2 times, most recently
from
November 24, 2020 21:06
c95d85d
to
cf5c893
Compare
Closed
3 tasks
…a jupyter notebook
…determine unicode support
norweeg
force-pushed
the
remove-terminal-check
branch
from
April 2, 2023 18:04
70c20de
to
34a9ce6
Compare
norweeg
changed the title
remove unnecessary system check for Unicode output
update check for Unicode support
Apr 2, 2023
@manrajgrover can you take a look at this?? AppVeyor is failing not on my code change, but at the environment setup for Python 3.7. It can't install pywinpyt which must be a dependency of something required for testing because a Go compiler is not installed on the test server. I believe once that problem is resolved, all tests will pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
removes unnecessary system check for Unicode outputchanges Unicode support check to instead use the encoder supported by
sys.stdout
to try to encode a Unicode character. If it succeeds, Unicode is supported, otherwise it is notresolves #5
resolves #25
resolves #141
obsoletes #142
see #5 (comment)
Checklist
Related Issues and Discussions
People to notify