Skip to content

chore(api): remove GCS, document Vercel Blob and CRON_SECRET in .env.example - #102

Merged
mankatcheung merged 2 commits into
mainfrom
chore/update-api-env-files
Jul 26, 2026
Merged

mankatcheung merged 2 commits into
mainfrom
chore/update-api-env-files

Conversation

@mankatcheung

@mankatcheung mankatcheung commented Jul 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • .env.example still described the pre-Vercel setup after ci: deploy api to Vercel with Vercel Blob storage #101 (Cloud Run → Vercel, GCS → Vercel Blob) merged — no BLOB_READ_WRITE_TOKEN, no CRON_SECRET, storage comment still said "gcs for production".
  • Added CRON_SECRET next to DIGEST_ADMIN_SECRET, explaining Vercel Cron's auto-injected-header mechanism.
  • GCS support removed entirely (per follow-up request — GCP is no longer in use for this project, not just for the storage backend):
    • Deleted GCSStorageProvider.ts and its test
    • Removed @google-cloud/storage dependency
    • Removed GCS_* env keys and the 'gcs' STORAGE_PROVIDER option from constants.ts
    • vercel-blob is now the only production storage option (local for dev)
    • Updated .env.example and CLAUDE.md's architecture section accordingly
  • Cross-checked every key in ENV (constants.ts) against .env.example programmatically — nothing missing.

Test plan

  • pnpm --filter @job-finder/api typecheck / build / test (732 passed) / lint / format:check
  • Verified every ENV key the API code reads has a corresponding line in .env.example

.env.example still described the pre-Vercel setup (GCS-only storage
options, no CRON_SECRET) after the Cloud Run -> Vercel migration.
Brings it in sync with STORAGE_PROVIDER=vercel-blob and the
CRON_SECRET / DIGEST_ADMIN_SECRET dual-auth on the digest/reminders
routes.
@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Hobby accounts are limited to daily cron jobs. This cron expression (0 * * * *) would run more than once per day. Upgrade to the Pro plan to unlock all Cron Jobs features on Vercel.

Learn More: https://vercel.link/3Fpeeb1

@coderabbitai

coderabbitai Bot commented Jul 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@mankatcheung, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 505efd8d-8ff3-4af8-a4d5-815133b46303

📥 Commits

Reviewing files that changed from the base of the PR and between 0f2718f and a3b7809.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • CLAUDE.md
  • apps/api/.env.example
  • apps/api/package.json
  • apps/api/src/__tests__/infrastructure/storage/GCSStorageProvider.test.ts
  • apps/api/src/constants.ts
  • apps/api/src/http/container.ts
  • apps/api/src/infrastructure/storage/GCSStorageProvider.ts
  • apps/api/src/infrastructure/storage/VercelBlobStorageProvider.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-api-env-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Vercel Blob is now the only production storage backend, and GCP is no
longer in use for this project. Deletes GCSStorageProvider and its
test, the @google-cloud/storage dependency, the GCS_* env vars, and
the 'gcs' STORAGE_PROVIDER option. Updates .env.example and CLAUDE.md
accordingly.
@mankatcheung mankatcheung changed the title chore(api): document Vercel Blob and CRON_SECRET in .env.example chore(api): remove GCS, document Vercel Blob and CRON_SECRET in .env.example Jul 26, 2026
@mankatcheung
mankatcheung merged commit 74d4954 into main Jul 26, 2026
5 of 6 checks passed
@mankatcheung
mankatcheung deleted the chore/update-api-env-files branch July 26, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant