Skip to content

Conversation

@fmorency
Copy link
Contributor

@fmorency fmorency commented May 9, 2025

This pull request refactors naming conventions in two Prometheus collectors (DenomInfoCollector and GeoIPCollector) to improve clarity and consistency. The changes primarily involve renaming descriptors and associated references to better align with their functionality.

Changes to DenomInfoCollector:

  • Renamed denomInfoDesc to denomMetaDesc and updated all references to reflect this change. This includes updates in the Describe, Collect, and collectDenomMetadata methods, as well as in the factory registration (RegisterCollectorFactory) to use "denom_metadata" instead of "denom_info". [1] [2] [3] [4] [5] [6] [7]

Changes to GeoIPCollector:

  • Renamed info to metadata and updated all references accordingly. This includes updates in the Describe and Collect methods, as well as changes to error reporting and metric creation logic. [1] [2] [3]

@fmorency fmorency requested a review from Copilot May 9, 2025 14:07
@fmorency fmorency self-assigned this May 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors naming conventions in two Prometheus collectors for improved clarity and consistency.

  • Renames "info" to "metadata" in GeoIPCollector, updating all related metric references.
  • Changes "denomInfoDesc" to "denomMetaDesc" in DenomInfoCollector, including updates in descriptor creation, usage in methods, and collector registration.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/collectors/geoip.go Updated struct field and all metric references from "info" to "metadata" to better reflect its purpose.
pkg/collectors/autodetect/manifestd/denom_info.go Renamed Prometheus descriptor from "denomInfoDesc" to "denomMetaDesc" and updated factory registration accordingly.

@fmorency fmorency merged commit e44c6f9 into manifest-network:main May 9, 2025
3 checks passed
@fmorency fmorency deleted the meta branch May 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant