feat: geoip collector and refactor

[fmorency]

This pull request introduces several changes to the Manifest Node Exporter project, focusing on restructuring the codebase, adding a new GeoIP collector, and improving modularity. The most significant changes include reorganizing the autodetect module, adding a GeoIP collector for geographical metrics, and updating dependencies.

Codebase Restructuring and Modularity Improvements:

• Moved autodetect functionality into the pkg/collectors/autodetect directory to improve module organization. This includes renaming files and updating package declarations accordingly. [1] [2] [3] [4] [5]
• Updated function visibility in pkg/collectors/common.go from private to public for reuse across modules (e.g., ReportUpMetric, ReportInvalidMetric, ValidateClient). [1] [2] [3]

GeoIP Collector Addition:

• Introduced a new GeoIPCollector in pkg/collectors/geoip.go to gather geographical metrics (latitude, longitude, and location info) based on the node's public IP. This includes HTTP client setup, Prometheus metric descriptors, and data collection logic.
• Integrated the GeoIP collector into the serve command by appending it to the list of collectors registered with Prometheus.

Dependency Updates:

• Added resty.dev/v3 as a new dependency in go.mod to facilitate HTTP requests in the GeoIP collector.

Documentation Enhancements:

• Added a README.md file for the autodetect module, providing an overview and purpose of the module's functionality.

Code Adjustments for Collector Reusability:

• Updated references to utility functions (e.g., ValidateClient, ReportUpMetric) in the renamed manifestd collectors to reflect their new location in the collectors package. [1] [2] [3] [4]

These changes collectively improve the modularity, functionality, and maintainability of the project.

[Copilot]

Pull Request Overview

This PR restructures the codebase by moving the autodetect module into a more organized location, introduces a new GeoIP collector to gather geographical metrics, and updates several common utility functions to be publicly accessible for reuse. Key changes include:

• Relocating and renaming files from the autodetect module into pkg/collectors/autodetect.
• Adding a GeoIP collector (pkg/collectors/geoip.go) with associated HTTP client and metric reporting logic.
• Updating utility functions in pkg/collectors/common.go and modifying monitor registration in cmd/serve.go, along with corresponding documentation updates.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/collectors/geoip.go	Introduces the new GeoIPCollector for fetching and reporting geographical metrics.
pkg/collectors/common.go	Updates utility functions to public scope for broader reuse.
pkg/collectors/autodetect/manifestd/*.go	Renames packages and updates calls to reflect new module structure.
pkg/collectors/autodetect/README.md	Adds documentation for the autodetect module.
cmd/serve.go	Integrates the new GeoIP collector with existing monitors.

Files not reviewed (1)

• go.mod: Language not supported

Comments suppressed due to low confidence (3)

pkg/collectors/geoip.go:1

• [nitpick] Consider adding package-level documentation in this file to clarify the purpose and usage of the GeoIPCollector, which helps future maintainers understand its role.

package collectors

pkg/collectors/common.go:25

• [nitpick] Consider renaming 'ValidateGrpcClient' to 'ValidateGRPCClient' to follow common acronym conventions for better readability.

func ValidateGrpcClient(client *client.GRPCClient) error {

pkg/collectors/autodetect/manifestd/token_count.go:1

• [nitpick] The package name 'manifestd' may be confusing given its location under 'pkg/collectors/autodetect'. Consider a naming convention that more clearly reflects its functionality within the collectors module.

package manifestd