fix: docs and minor fixes

[fmorency]

This pull request introduces a new Prometheus exporter for Manifest blockchain nodes and includes several enhancements, fixes, and cleanups across the codebase. The most significant changes include the addition of a detailed README.md file, updates to metric names for consistency, removal of unused configuration fields, and cleanup of redundant comments in the code.

Documentation Updates:

• README.md: Added comprehensive documentation for the Manifest Node Exporter, including installation instructions, usage examples, global and serve flags, and a list of available metrics.

Metric Name Updates:

• pkg/collectors/grpc/token_count.go: Updated metric names to align with naming conventions:
  • Changed manifest_tokenomics_token_number to manifest_tokenomics_token_count.
  • Changed manifest_tokenomics_supply_grpc_up to manifest_tokenomics_count_grpc_up.
• tests/e2e_serve_test.go: Updated test cases to reflect the new metric names.

Configuration Simplifications:

• pkg/config.go: Removed unused MaxConcurrency and MaxRetries fields from the ServeConfig struct and their associated validations and loading logic. [1] [2]

Code Cleanup:

• cmd/serve.go: Updated the default listen-address flag value to 0.0.0.0:2112 and removed redundant comments. [1] [2]
• pkg/metrics_server.go: Simplified error handling in Start and Shutdown methods by removing unnecessary comments and redundant logic. [1] [2]
• pkg/collectors/grpc/registry.go: Cleaned up comments and removed unused code related to Prometheus collector registration. [1] [2]

[Copilot]

Pull Request Overview

This pull request introduces a new Prometheus exporter for Manifest blockchain nodes along with several minor fixes and documentation updates. Key changes include updating metric names for consistency, removing unused configuration fields, and cleaning up redundant code and comments across the codebase.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/e2e_serve_test.go	Updated test cases to match the revised metric names.
pkg/metrics_server.go	Simplified error handling by removing unnecessary comments and redundant logic.
pkg/config.go	Removed unused fields and associated validations from the ServeConfig struct.
pkg/collectors/grpc/token_count.go	Updated metric descriptors to reflect the new naming convention for metrics.
pkg/collectors/grpc/registry.go	Cleaned up comments and removed unused code while ensuring proper logging behavior.
cmd/serve.go	Changed the default listen address to "0.0.0.0:2112" and removed redundant comments.
README.md	Added comprehensive documentation for the Manifest Node Exporter.