Skip to content

Conversation

@fmorency
Copy link
Contributor

This pull request modifies the .circleci/config.yml file to deprecate the use of the Docker job and related steps while updating the Go module cache handling. The changes streamline the CI configuration by focusing on Go-related tasks and removing Docker-related functionality.

Deprecation of Docker-related functionality:

  • Commented out the docker orb and all associated steps, including building, pushing, and tagging Docker images, as well as storing Docker-related artifacts. This includes the removal of the docker job from workflows and its branch filters. [1] [2] [3]

Updates to Go module cache handling:

  • Replaced go/load-cache and go/save-cache steps with go/load-mod-cache and go/save-mod-cache to align with updated Go module caching practices.

@fmorency fmorency requested a review from Copilot June 12, 2025 13:53
@fmorency fmorency self-assigned this Jun 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates Docker-related CI steps and updates Go module cache handling in the CircleCI configuration.

  • Commented out the Docker orb and its associated build/push jobs.
  • Replaced go/load-cache/go/save-cache with go/load-mod-cache/go/save-mod-cache.
  • Adjusted the Codecov upload step from file to files.
Comments suppressed due to low confidence (3)

.circleci/config.yml:21

  • Verify that circleci/[email protected] supports the go/load-mod-cache and go/save-mod-cache steps; if not, upgrade the orb or revert to the cache step names your current orb supports to avoid CI failures.
-      - go/load-mod-cache:

.circleci/config.yml:28

  • The files parameter for codecov/upload expects a YAML sequence. For a single file, use files: ['/tmp/manifest-node-exporter-coverage/coverage-merged.out'] or switch back to file: if the orb version requires it.
-          files: /tmp/manifest-node-exporter-coverage/coverage-merged.out

.circleci/config.yml:10

  • [nitpick] Since Docker support is deprecated here, consider removing these commented-out lines entirely to clean up the CI config instead of leaving them in place.
#  docker: circleci/[email protected]

@fmorency fmorency merged commit abf25eb into manifest-network:main Jun 12, 2025
3 checks passed
@fmorency fmorency deleted the fix-ci branch June 12, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant