Skip to content

fix: removed unused dependencies that made Angular crash #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: removed unused dependencies that made Angular crash #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dfe6c8
fix: removed unused depencies that made angular crash
gpillon Feb 13, 2023
e03db10
changed port
gpillon Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"ng": "ng",
"start": "npm run start:shell",
"start:shell": "ng serve shell -o --port 5000",
"start:mfe1": "ng serve mfe1 -o --port 3000",
"start:mfe1": "ng serve mfe1 -o --port 3001",
"start:all": "concurrently \"npm run start:shell\" \"npm run start:mfe1\" ",
"build:shell": "ng build shell --prod",
"build:shell": "ng build shell --configuration=production",
"build:mfe1": "ng build mfe1 --prod",
"serve:dist": "concurrently \"serve dist/shell -l 5000 -s\" \"serve dist/mfe1 -l 3000 -s\" ",
"build": "npm run build:shell && npm run build:mfe1",
Expand Down
2 changes: 1 addition & 1 deletion projects/shell/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, ViewChild, ViewContainerRef, ɵrenderComponent as renderComponent, Inject, Injector, ComponentFactoryResolver } from '@angular/core';
import { Component } from '@angular/core';
import { AuthLibService } from 'auth-lib';
import { HttpClient } from '@angular/common/http';

Expand Down
4 changes: 2 additions & 2 deletions projects/shell/src/assets/mf.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mfe1": "http://localhost:3000/remoteEntry.js"
}
"mfe1": "http://localhost:3001/remoteEntry.js"
}
14 changes: 7 additions & 7 deletions projects/shell/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@
padding-top: 80px;
padding-left: 10px;
}

ul {
list-style-type: none;
margin: 0;
padding: 0;
overflow: hidden;
background-color: #333;

position: fixed;
top: 0;
left: 0;
width: 100%;
}

li {
float: left;
height: 50px;
margin-top: auto;
margin-bottom: auto;
}

li a {
display: block;
color: white;
Expand All @@ -44,7 +44,7 @@
text-decoration: none;
cursor: pointer;
}

li a:hover {
background-color: #111;
}
Expand All @@ -54,7 +54,7 @@
<body>
<app-root></app-root>
<!-- Shell -->
<!-- <script src="http://localhost:3000/remoteEntry.js"></script> -->
<!-- doItWebpack({mfe1: 'http://localhost:3000/remoteEntry.js'}) -->
<!-- <script src="http://localhost:3001/remoteEntry.js"></script> -->
<!-- doItWebpack({mfe1: 'http://localhost:3001/remoteEntry.js'}) -->
</body>
</html>
2 changes: 1 addition & 1 deletion projects/shell/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { loadManifest } from '@angular-architects/module-federation';

loadManifest("/assets/mf.manifest.json")
loadManifest('/assets/mf.manifest.json')
.catch(err => console.error(err))
.then(_ => import('./bootstrap'))
.catch(err => console.error(err));
Loading