feat: add ignore option #131
Conversation
src/sync_drive.py
Outdated
| """Check if folder is wanted.""" | ||
| if ignore: | ||
| if PathSpec.from_lines("gitwildmatch", ignore).match_file(f"{folder_path}/foo.bar"): |
There was a problem hiding this comment.
f"{folder_path}/foo.bar" shouldn't this be folder_path?
There was a problem hiding this comment.
This is necessary 😕. If you remove /foo.bar the tests will not pass
If you have another suggestion, I can try it.
There was a problem hiding this comment.
Looks like cpburnz/python-pathspec#65 is causing the tests to fail. Seems like pathspec isn't the right fit for our needs. 😕
It might be easier to use something like https://pymotw.com/3/glob/ or our own implementation to check if entries in ignore list matches the path and then return False to ignore it.
There was a problem hiding this comment.
Glob is useful to find filenames, but do not seems helpful for testing path
There was a problem hiding this comment.
Looks like glob internally uses fnmatch. fnmatch seems to be a good fit for this feature.
There was a problem hiding this comment.
I've just tried fnmatch it's the same problem
Allow to ignore folders and files
This required the installation of pathspec, to have the format like the
.gitignoreCloses #48 and #80