fix(debugger): improve output when constrain fails

[anaPerezGhiglia]

Description

When an assertion fails on Brillig mode, the debugger fails to indicate the user where the program failed

while when running on ACIR mode it provides enough information 👇

Problem

Resolves

Summary

Context

assert constraints are translated as "jump to trap" if the condition is not met when running in Brillig mode

Changes

• Add a new field to OpcodeResolutionError::BrilligFunctionFailed to track whether the function failed due to a trap opcode or not
• Modify BrilligFunctionFailed Display implementation when function failed due to a Trap
  • for doing this I had to remove the usage of Error derive macro, to have a conditional message
  • I decided it was better to have this way rather than just having a new type only for the convenience of the macro

Observations

• TODO: should we return solver ownership in all Err scenarios>?

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

[mverzilli]

if it doesn't throw you into borrow checker hell, maybe it's a good idea to move the left hand side of let payload = ... to a function, for readability

[mverzilli]

Having a boolean capture this doesn't feel right, have you considered just adding the FailureReason here? (so instead of found_trap: bool, you'd end up with reason: FailureReason)

[anaPerezGhiglia]

Closing this PR in favor of #6