-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options/posix: Implement dladdr1 #1008
Conversation
IMO both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments.
6f27634
to
7e23d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but this needs to be PR'ed against abi-break
now.
Done. |
40fe204
to
80b0943
Compare
This is also a gnu extension so I am not sure if it should be guarded behind _GNU_SOURCE or __MLIBC_GLIBC_OPTION but it doesn't look like the existing
dladdr
is guarded either.