Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options/posix: Implement dladdr1 #1008

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Feb 19, 2024

This is also a gnu extension so I am not sure if it should be guarded behind _GNU_SOURCE or __MLIBC_GLIBC_OPTION but it doesn't look like the existing dladdr is guarded either.

@no92
Copy link
Member

no92 commented Feb 19, 2024

IMO both dladdr and dladdr1 should be guarded behind __MLIBC_GLIBC_OPTION and _GNU_SOURCE.

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments.

options/posix/include/dlfcn.h Show resolved Hide resolved
options/posix/include/dlfcn.h Outdated Show resolved Hide resolved
@Qwinci Qwinci force-pushed the dladdr1 branch 4 times, most recently from 6f27634 to 7e23d68 Compare February 19, 2024 16:25
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this needs to be PR'ed against abi-break now.

@Qwinci Qwinci changed the base branch from master to abi-break February 21, 2024 08:15
@Qwinci
Copy link
Contributor Author

Qwinci commented Feb 21, 2024

Done.

@Geertiebear Geertiebear merged commit 147eb24 into managarm:abi-break Feb 24, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants