Skip to content
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2b25ad8
test: cover zero-gap listener takeover
lawrencecchen Aug 6, 2026
c45eddf
fix: hand off live listeners without rebinding
lawrencecchen Aug 6, 2026
713de18
fix: complete zero-gap listener handoff
lawrencecchen Aug 6, 2026
c7ba53a
fix: isolate zero-gap listener transfer
lawrencecchen Aug 6, 2026
2ec7ee2
fix: make listener transfer targets explicit
lawrencecchen Aug 6, 2026
895a15f
fix: close cutover evidence gaps
lawrencecchen Aug 6, 2026
a34cf0d
fix: make handoff recovery and shutdown reliable
lawrencecchen Aug 6, 2026
8f131bc
fix: preserve public ownership after legacy stop
lawrencecchen Aug 6, 2026
f120780
fix: make committed listener handoffs resumable
lawrencecchen Aug 6, 2026
258f61a
fix: tighten cutover evidence validation
lawrencecchen Aug 6, 2026
5020c45
fix: preserve public listener across front restarts
lawrencecchen Aug 6, 2026
8b98878
fix: retain same-address handoff across restart
lawrencecchen Aug 6, 2026
1bc3b80
fix: recover from interrupted listener transitions
lawrencecchen Aug 6, 2026
16b7d8a
fix: defer bootstrap monitor switch until recovery
lawrencecchen Aug 6, 2026
2116eb8
fix: make listener retention updates failure-safe
lawrencecchen Aug 6, 2026
55ac3b3
fix: key retained listeners by canonical address
lawrencecchen Aug 6, 2026
2582912
fix: validate listener migration inputs early
lawrencecchen Aug 6, 2026
4e98e9f
fix: keep accepting while front sessions drain
lawrencecchen Aug 6, 2026
3783fd2
fix: hand off front process before draining
lawrencecchen Aug 6, 2026
7cd1fe5
fix: commit control socket ownership after promotion
lawrencecchen Aug 6, 2026
1d07775
fix: enforce platform and inode evidence boundaries
lawrencecchen Aug 6, 2026
7b8214d
fix: require retirement before destination proof
lawrencecchen Aug 6, 2026
a154bb5
fix: await systemd main pid promotion
lawrencecchen Aug 6, 2026
3a86942
fix: gate successor ownership and controls
lawrencecchen Aug 6, 2026
7bc0496
fix: roll back confirmed successor exits
lawrencecchen Aug 6, 2026
ed417e8
test: cover front ownership recovery races
lawrencecchen Aug 6, 2026
b1ad519
fix: make front ownership recovery fail safe
lawrencecchen Aug 6, 2026
a530ab5
test: cover durable listener replacement
lawrencecchen Aug 6, 2026
d593563
test: fix Linux listener barrier harness
lawrencecchen Aug 6, 2026
52d7d5a
fix: persist active listener before replacement
lawrencecchen Aug 6, 2026
d668191
test: cover non-Linux front reload signals
lawrencecchen Aug 6, 2026
c81791b
fix: limit front hot reload signals to Linux
lawrencecchen Aug 6, 2026
b3cab43
test: close listener handoff review gaps
lawrencecchen Aug 6, 2026
99dac10
test: cover ambiguous successor activation
lawrencecchen Aug 6, 2026
ac8e838
fix: retire ambiguous front activations gracefully
lawrencecchen Aug 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions cmd/subrouter-transport-observer/golden.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const (
goldenPinnedBootstrapTag = "v0.1.63"
goldenPinnedBootstrapLinuxSHA256 = "39fcd2c3a86c7be12759ed0f0b366d9d13f90e538c2af2483dd50230c9ef2bf2"
goldenPinnedBootstrapRevision = "763dcf6c304d9aea7f36659d4fba40ea27f42096"
goldenPinnedCandidateTag = "v0.1.68"
goldenPinnedCandidateTag = "v0.1.69"
goldenResponseRequestTokenEnv = "SUBROUTER_GOLDEN_RESPONSE_REQUEST_TOKEN"
goldenFakeStreamReleaseTokenEnv = "SUBROUTER_GOLDEN_FAKE_STREAM_RELEASE_TOKEN"
goldenFakeStreamReleaseStateEnv = "SUBROUTER_GOLDEN_FAKE_STREAM_RELEASE_STATE"
Expand Down Expand Up @@ -97,6 +97,7 @@ type goldenOptions struct {
releasedClient string
artifactDir string
model string
accountID string
streamLines int
timeout time.Duration
migrationPrepare []string
Expand Down Expand Up @@ -147,8 +148,9 @@ func parseGoldenArgs(args []string) (goldenOptions, error) {
flags.StringVar(&options.predecessorClient, "predecessor-client", "", "locally verified pinned predecessor release asset")
flags.StringVar(&options.releasedClient, "released-client", "", "test-only released client override")
flags.StringVar(&options.artifactDir, "artifact-dir", "", "content-blind evidence directory")
flags.StringVar(&options.model, "model", "gpt-5.6-sol", "Codex model")
flags.IntVar(&options.streamLines, "stream-lines", 4000, "numbered lines requested from each continuity turn")
flags.StringVar(&options.model, "model", "gpt-5.3-codex-spark", "Codex model")
flags.StringVar(&options.accountID, "account-id", "", "Subrouter OAuth account selected for every golden Codex session")
flags.IntVar(&options.streamLines, "stream-lines", 400, "numbered lines requested from each continuity turn")
flags.DurationVar(&options.timeout, "timeout", 20*time.Minute, "overall golden gate timeout")
if err := flags.Parse(args[:positions[actionNames[0]]]); err != nil {
return options, err
Expand All @@ -172,6 +174,10 @@ func parseGoldenArgs(args []string) (goldenOptions, error) {
if options.timeout <= 0 {
return options, errors.New("--timeout must be positive")
}
options.accountID = strings.TrimSpace(options.accountID)
if len(options.accountID) > 320 || strings.ContainsAny(options.accountID, "\r\n\x00") {
return options, errors.New("--account-id is invalid")
}
if !goldenTestHooks.enabled {
version := strings.TrimPrefix(strings.TrimSpace(options.releasedVersion), "v")
if version != goldenPinnedPredecessorVersion ||
Expand All @@ -181,6 +187,9 @@ func parseGoldenArgs(args []string) (goldenOptions, error) {
if strings.TrimSpace(options.evidenceValidator) == "" {
return options, errors.New("--deploy-evidence-validator is required")
}
if options.accountID == "" {
return options, errors.New("--account-id is required for a deterministic golden credential")
}
if strings.TrimSpace(options.candidateTag) != goldenPinnedCandidateTag || !validGoldenSHA256(options.candidateSHA256) ||
len(strings.TrimSpace(options.candidateRevision)) != 40 {
return options, fmt.Errorf("the golden candidate must be the verified immutable %s release", goldenPinnedCandidateTag)
Expand Down Expand Up @@ -303,8 +312,6 @@ type goldenSummary struct {
ReleasePlatform string `json:"release_platform"`
ProbeFrequencyHz int `json:"probe_frequency_hz"`
MigrationPreparation goldenActionSummary `json:"migration_preparation"`
MigrationRehearsalCutover goldenActionSummary `json:"migration_rehearsal_cutover"`
MigrationRollback goldenActionSummary `json:"migration_rollback"`
MigrationFinalCutover goldenActionSummary `json:"migration_final_cutover"`
LegacyCleanup goldenActionSummary `json:"legacy_cleanup"`
Activation goldenActionSummary `json:"activation"`
Expand Down Expand Up @@ -792,8 +799,6 @@ func (r *goldenRunner) run(ctx context.Context) (runErr error) {
return err
}
r.summary.MigrationPreparation = migration.preparation
r.summary.MigrationRehearsalCutover = migration.rehearsalCutover
r.summary.MigrationRollback = migration.rollback
r.summary.MigrationFinalCutover = migration.finalCutover
r.summary.LegacyCleanup = migration.cleanup
if err := validateGoldenCounterContinuity(*r.summary); err != nil {
Expand Down Expand Up @@ -2739,6 +2744,9 @@ func (r *goldenRunner) launchSession(ctx context.Context, clientPath string, ses
"SUBROUTER_STATE_DIR": filepath.Join(session.home, ".subrouter"),
goldenResponseRequestTokenEnv: session.streamReleaseToken,
}
if r.options.accountID != "" {
overrides["SUBROUTER_CODEX_ACCOUNT_ID"] = r.options.accountID
}
if session.route == "local-egress" {
overrides["SUBROUTER_LOCAL_BASE_URL"] = session.baseURL
}
Expand Down Expand Up @@ -4589,10 +4597,8 @@ func validateGoldenSummary(summary goldenSummary, testMode bool) error {
}
expected["migration-"+suffix] = struct{ route, transport string }{route: route, transport: transport}
}
migrationDestinationLabels := make([]string, 0, 3)
migrationDestinationLabels := make([]string, 0, 1)
for _, baseLabel := range []string{
"migration-candidate-front-rehearsal-destination-direct",
"migration-candidate-legacy-rollback-destination-direct",
"migration-candidate-front-final-destination-direct",
} {
label, err := goldenMigrationDestinationSessionLabel(summary.Sessions, baseLabel)
Expand Down Expand Up @@ -4669,13 +4675,13 @@ func validateGoldenSummary(summary goldenSummary, testMode bool) error {
}
requiredProcessEvidence := make(map[string]bool)
for _, suffix := range []string{"direct-websocket", "direct-http"} {
requiredProcessEvidence["migration-before-rehearsal-cutover\x00migration-"+suffix] = false
requiredProcessEvidence["migration-after-final-cutover\x00migration-"+suffix] = false
requiredProcessEvidence["migration-before-listener-handoff\x00migration-"+suffix] = false
requiredProcessEvidence["migration-after-listener-handoff\x00migration-"+suffix] = false
}
requiredProcessEvidence["migration-before-rehearsal-cutover\x00local-daemon"] = false
requiredProcessEvidence["migration-after-final-cutover\x00local-daemon"] = false
requiredProcessEvidence["migration-before-listener-handoff\x00local-daemon"] = false
requiredProcessEvidence["migration-after-listener-handoff\x00local-daemon"] = false
for _, label := range migrationDestinationLabels {
requiredProcessEvidence["migration-after-final-cutover\x00"+label] = false
requiredProcessEvidence["migration-after-listener-handoff\x00"+label] = false
}
for _, cycle := range []string{"rehearsal", "final"} {
phases := []string{cycle + "-before-activation", cycle + "-after-activation"}
Expand Down
101 changes: 74 additions & 27 deletions cmd/subrouter-transport-observer/golden_acceptance_regression_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ func TestGoldenSummaryRejectsActivationAtOrAboveThirtySeconds(t *testing.T) {

func TestGoldenMigrationUsesBoundedRoutePropagationWindow(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-rollback", strings.Repeat("1", 64), strings.Repeat("2", 64),
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
evidence.Timestamps.ActivatedAt = "2026-08-02T00:04:59.000Z"
evidence.Timestamps.SourceListenerRetiredAt = "2026-08-02T00:00:01Z"
evidence.DestinationProof.ObservedAt = evidence.Timestamps.ActivatedAt
evidence.DestinationProof.ReceivedAt = "2026-08-02T00:04:59.500Z"
evidence.DestinationProof.PostSnapshotLiveness.RequestedAt = "2026-08-02T00:04:59.600Z"
Expand All @@ -39,6 +40,7 @@ func TestGoldenMigrationUsesBoundedRoutePropagationWindow(t *testing.T) {
}

evidence.Timestamps.ActivatedAt = "2026-08-02T00:05:00.000Z"
evidence.Timestamps.SourceListenerRetiredAt = "2026-08-02T00:00:01Z"
evidence.DestinationProof.ObservedAt = evidence.Timestamps.ActivatedAt
evidence.DestinationProof.ReceivedAt = evidence.Timestamps.ActivatedAt
evidence.DestinationProof.PostSnapshotLiveness.RequestedAt = "2026-08-02T00:05:00.001Z"
Expand All @@ -50,9 +52,27 @@ func TestGoldenMigrationUsesBoundedRoutePropagationWindow(t *testing.T) {
}
}

func TestGoldenMigrationRequiresListenerRetirementBeforeFreshPublicProof(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
evidence.Timestamps.SourceListenerRetiredAt = "2026-08-02T00:00:01.1Z"
if err := validateGoldenMigrationTransition(evidence, "front-migration-cutover"); err == nil {
t.Fatal("fresh public proof observed before source listener retirement was accepted")
}

evidence = validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
evidence.Timestamps.SourceListenerRetiredAt = "2026-08-01T23:59:59.999Z"
if err := validateGoldenMigrationTransition(evidence, "front-migration-cutover"); err == nil {
t.Fatal("source listener retirement before the transition request was accepted")
}
}

func TestGoldenMigrationSummaryPreservesRoutePropagationWindow(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-rollback", strings.Repeat("1", 64), strings.Repeat("2", 64),
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
evidence.Timestamps.ActivatedAt = "2026-08-02T00:04:59.123Z"
evidence.DestinationProof.ObservedAt = evidence.Timestamps.ActivatedAt
Expand All @@ -77,7 +97,7 @@ func TestGoldenMigrationSummaryPreservesRoutePropagationWindow(t *testing.T) {

func TestGoldenMigrationAllowsConcurrentDestinationConnectionDrain(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-rollback", strings.Repeat("1", 64), strings.Repeat("2", 64),
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
evidence.Destination.Before.PublicConnections = 14
evidence.Destination.Before.GenerationConnections = 14
Expand Down Expand Up @@ -120,7 +140,7 @@ func TestGoldenMigrationAllowsConcurrentDestinationConnectionDrain(t *testing.T)

func TestGoldenMigrationRejectsMissingPostSnapshotConnectionLiveness(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-rollback", strings.Repeat("1", 64), strings.Repeat("2", 64),
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
data, err := json.Marshal(evidence)
if err != nil {
Expand Down Expand Up @@ -300,7 +320,7 @@ func TestGoldenObserverClosureScopesErrorsToResponseRequests(t *testing.T) {

func TestGoldenMigrationTransitionRejectsRetargetedRoutingSelectors(t *testing.T) {
evidence := validGoldenMigrationTransitionEvidence(
"final-cutover", "front-migration-rollback", strings.Repeat("1", 64), strings.Repeat("2", 64),
"final-cutover", "front-migration-preparation", strings.Repeat("1", 64), strings.Repeat("2", 64),
)
validatePython := func(value *goldenMigrationEvidence) error {
t.Helper()
Expand Down Expand Up @@ -876,10 +896,10 @@ func TestGoldenStableSessionAcceptsSocketTurnoverAfterBoundaryProof(t *testing.T
observer: &runningGoldenObserver{stats: stats}, transportSocketStable: true,
}
before := map[string]goldenProcessEvidence{
session.label: {Label: session.label, Phase: "migration-before-rehearsal-cutover", SocketIDs: []string{beforeConnection}},
session.label: {Label: session.label, Phase: "migration-before-listener-handoff", SocketIDs: []string{beforeConnection}},
}
after := map[string]goldenProcessEvidence{
session.label: {Label: session.label, Phase: "migration-after-final-cutover", SocketIDs: []string{afterConnection}},
session.label: {Label: session.label, Phase: "migration-after-listener-handoff", SocketIDs: []string{afterConnection}},
}
if err := requireStableSessionSockets([]*goldenSession{session}, before, after); err != nil {
t.Fatalf("normal follow-on response was rejected after exact transition-boundary proof: %v", err)
Expand Down Expand Up @@ -1238,6 +1258,14 @@ func validGoldenMigrationTransitionEvidence(mode, priorType, priorSHA, preparati
evidence.Routing.DestinationBackendURL = map[string]string{
"legacy": evidence.Routing.LegacyBackendURL, "front": evidence.Routing.FrontBackendURL,
}[destination]
if evidenceType == "front-migration-cutover" {
evidence.Routing.DestinationBackendURL = evidence.Routing.LegacyBackendURL
evidence.Routing.Mechanism = "listener-fd-takeover"
evidence.Listener = goldenMigrationListener{
SourcePID: 101, SourceFD: 3, SourceInode: "socket:[123]",
DestinationPID: 202, DestinationFD: 7, DestinationInode: "socket:[123]", SameKernelSocket: true,
}
}
sourceGeneration, destinationGeneration := "legacy-generation", "front-generation"
if source == "front" {
sourceGeneration, destinationGeneration = destinationGeneration, sourceGeneration
Expand All @@ -1253,7 +1281,8 @@ func validGoldenMigrationTransitionEvidence(mode, priorType, priorSHA, preparati
ConnectionCountDelta: 1,
}
evidence.Timestamps = goldenMigrationTimestamps{
TransitionRequestedAt: "2026-08-02T00:00:00Z", ActivatedAt: "2026-08-02T00:00:01Z",
TransitionRequestedAt: "2026-08-02T00:00:00Z", SourceListenerRetiredAt: "2026-08-02T00:00:00.5Z",
ActivatedAt: "2026-08-02T00:00:01Z",
EvidenceEmittedAt: "2026-08-02T00:00:02Z",
}
evidence.DestinationProof = goldenMigrationDestinationProof{
Expand Down Expand Up @@ -1287,7 +1316,7 @@ func validGoldenMigrationTransitionEvidence(mode, priorType, priorSHA, preparati
evidence.Metrics.SourceService, evidence.Metrics.DestinationService = "slot", "legacy"
}
evidence.Continuity = goldenMigrationContinuity{ExpectedExternalConnections: goldenInt64(expected), Preserved: goldenBool(true)}
required, performed := mode == "rehearsal-cutover", mode == "rollback"
required, performed := false, mode == "rollback"
evidence.Rollback = goldenMigrationRollback{Required: goldenBool(required), Performed: goldenBool(performed)}
return evidence
}
Expand All @@ -1296,7 +1325,10 @@ func validGoldenLegacyRetirementEvidence(cutoverSHA, preparationSHA string) *gol
evidence := validGoldenMigrationBaseEvidence("legacy-retirement", "final-cutover")
evidence.CutoverEvidenceSHA256 = cutoverSHA
evidence.PreparationEvidenceSHA256 = preparationSHA
evidence.Routing = goldenMigrationRouting{Active: "front", LegacyBackendRetained: true}
evidence.Routing = goldenMigrationRouting{
Active: "front", LegacyBackendURL: "https://example.test/legacy", ActiveBackendURL: "https://example.test/legacy",
Mechanism: "listener-fd-takeover", LegacyBackendRetained: true,
}
evidence.Routing.AcceptingNewPublic = false
evidence.Connections = goldenMigrationConnections{
Before: goldenMigrationConnectionSnapshot{Active: 1, Total: 1},
Expand Down Expand Up @@ -1377,8 +1409,6 @@ func validGoldenAcceptanceSummary() goldenSummary {
labels = append(labels,
struct{ label, route, transport string }{"migration-direct-websocket", "direct-hosted", "websocket"},
struct{ label, route, transport string }{"migration-direct-http", "direct-hosted", "http"},
struct{ label, route, transport string }{"migration-candidate-front-rehearsal-destination-direct", "direct-hosted", "http"},
struct{ label, route, transport string }{"migration-candidate-legacy-rollback-destination-direct", "direct-hosted", "http"},
struct{ label, route, transport string }{"migration-candidate-front-final-destination-direct", "direct-hosted", "http"},
)
for _, cycle := range []string{"rehearsal", "final"} {
Expand All @@ -1405,20 +1435,10 @@ func validGoldenAcceptanceSummary() goldenSummary {
summary.FinalActivation.EvidenceSHA256 = strings.Repeat("f", 64)
summary.FinalOldGenerationCleanup = cleanup("generation-a", "slot-a", "slot-b", summary.FinalActivation.EvidenceSHA256, strings.Repeat("2", 64), "deploy")
preparationSHA := strings.Repeat("3", 64)
rehearsalSHA := strings.Repeat("4", 64)
migrationRollbackSHA := strings.Repeat("5", 64)
finalCutoverSHA := strings.Repeat("6", 64)
summary.MigrationPreparation = validGoldenMigrationAction(validGoldenMigrationPreparationEvidence(), preparationSHA, "migration-preparation.json")
summary.MigrationRehearsalCutover = validGoldenMigrationAction(
validGoldenMigrationTransitionEvidence("rehearsal-cutover", "front-migration-preparation", preparationSHA, preparationSHA),
rehearsalSHA, "migration-rehearsal.json",
)
summary.MigrationRollback = validGoldenMigrationAction(
validGoldenMigrationTransitionEvidence("rollback", "front-migration-cutover", rehearsalSHA, preparationSHA),
migrationRollbackSHA, "migration-rollback.json",
)
summary.MigrationFinalCutover = validGoldenMigrationAction(
validGoldenMigrationTransitionEvidence("final-cutover", "front-migration-rollback", migrationRollbackSHA, preparationSHA),
validGoldenMigrationTransitionEvidence("final-cutover", "front-migration-preparation", preparationSHA, preparationSHA),
finalCutoverSHA, "migration-final.json",
)
summary.LegacyCleanup = validGoldenMigrationAction(
Expand Down Expand Up @@ -1451,14 +1471,12 @@ func validGoldenAcceptanceSummary() goldenSummary {
}
summary.Sessions = append(summary.Sessions, session)
}
for _, phase := range []string{"migration-before-rehearsal-cutover", "migration-after-final-cutover"} {
for _, phase := range []string{"migration-before-listener-handoff", "migration-after-listener-handoff"} {
migrationLabels := []string{
"migration-direct-websocket", "migration-direct-http", "local-daemon",
}
if phase == "migration-after-final-cutover" {
if phase == "migration-after-listener-handoff" {
migrationLabels = append(migrationLabels,
"migration-candidate-front-rehearsal-destination-direct",
"migration-candidate-legacy-rollback-destination-direct",
"migration-candidate-front-final-destination-direct",
)
}
Expand Down Expand Up @@ -1505,3 +1523,32 @@ func TestGoldenAcceptanceSummaryFixtureIsValid(t *testing.T) {
t.Fatalf("valid fixture rejected: %v", err)
}
}

func TestGoldenAcceptanceRejectsRetirementBackendUnlinkedFromCutover(t *testing.T) {
summary := validGoldenAcceptanceSummary()
summary.LegacyCleanup.migrationCanonical.Routing.LegacyBackendURL = "https://example.test/front"
summary.LegacyCleanup.migrationCanonical.Routing.ActiveBackendURL = "https://example.test/front"
if err := validateGoldenSummary(summary, false); err == nil {
t.Fatal("retirement evidence for a backend unrelated to the linked cutover was accepted")
}
}

func TestGoldenLegacyRetirementRejectsActiveBackendMismatch(t *testing.T) {
evidence := validGoldenLegacyRetirementEvidence(strings.Repeat("6", 64), strings.Repeat("3", 64))
evidence.Routing.ActiveBackendURL = "https://example.test/front"
if err := validateGoldenMigrationEvidence(evidence, "legacy-retirement"); err == nil {
t.Fatal("Go validator accepted retirement on a non-legacy backend")
}
data, err := json.Marshal(evidence)
if err != nil {
t.Fatal(err)
}
path := filepath.Join(t.TempDir(), "legacy-retirement.json")
if err := os.WriteFile(path, data, 0o600); err != nil {
t.Fatal(err)
}
validator := filepath.Join("..", "..", "deploy", "gcp", "validate-deploy-evidence.py")
if output, err := exec.Command("python3", validator, "--expect", "legacy-retirement", path).CombinedOutput(); err == nil {
t.Fatalf("Python validator accepted retirement on a non-legacy backend: %s", output)
}
}
2 changes: 0 additions & 2 deletions cmd/subrouter-transport-observer/golden_counter_continuity.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ func (chain *goldenCounterChain) observeSlotAction(evidence *goldenDeployEvidenc
func validateGoldenCounterContinuity(summary goldenSummary) error {
chain := goldenCounterChain{values: make(map[string][2]int64)}
for _, action := range []goldenActionSummary{
summary.MigrationRehearsalCutover,
summary.MigrationRollback,
summary.MigrationFinalCutover,
} {
if action.migrationCanonical == nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func TestGoldenMigrationValidationFailureRunsDeploymentActionCleanup(t *testing.
}
source := &goldenSession{}
_, _, err := runner.runMigrationTransitionWithProof(
context.Background(), "rehearsal-cutover", "migration-cleanup", prior,
context.Background(), "final-cutover", "migration-cleanup", prior,
goldenCycleInputs{}, []*goldenSession{source}, []*goldenContinuityMonitor{{}},
)
if got := fixedGoldenFailure(err); got != "migration_destination_proof_request_invalid" {
Expand Down
Loading