Skip to content

fix: suppress motion reports during a cmd-clicked link drag (follow-up to #74) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 1 commit into from
Jun 5, 2026
Merged

fix: suppress motion reports during a cmd-clicked link drag (follow-up to #74) #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Surface.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4749,6 +4749,18 @@ pub fn cursorPosCallback(
}
}

// The ctrl/super link-activation chord reserves the whole click for
// the terminal (link activation / smart-select; see
// mouseButtonCallback), so a drag while it is held must not leak
// button-motion reports to a mouse-grabbing program either. Mirror the
// shift override above: only suppress while a button is pressed so pure
// movement reports are unaffected. Part of manaflow-ai/cmux#5128.
if (self.mouse.mods.equal(input.ctrlOrSuper(.{}))) {
for (self.mouse.click_state) |state| {
if (state != .release) break :report;
}
}

// We use the first mouse button we find pressed in order to report
// since the spec (afaict) does not say...
const button: ?input.MouseButton = button: for (self.mouse.click_state, 0..) |state, i| {
Expand Down
Loading