Skip to content

Make initial route timeout tests owner-driven - #9993

Merged
lawrencecchen merged 1 commit into
feat-tui-iroh-iosfrom
task-tui-initial-route-deadline-owner
Aug 11, 2026
Merged

lawrencecchen merged 1 commit into
feat-tui-iroh-iosfrom
task-tui-initial-route-deadline-owner

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Tests for initial route fallback used the same 20 ms wall-clock deadline for the hanging route and the valid Unix fallback. Under Valgrind, the fallback also expired.

This change injects a test-only deadline owner. Each test waits for the hanging provider or link to start, expires only that route, and awaits Unix selection under one final watchdog. Production still uses one absolute Tokio deadline across provider and link setup.

Red evidence: https://github.com/manaflow-ai/cmux/actions/runs/31498625744


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Makes initial-route timeout tests owner-driven to fix Valgrind flakes. Tests now expire only the hanging route and reliably fall back to Unix, while production behavior stays the same.

  • Bug Fixes
    • Added InitialAttemptDeadlineOwner with a manual test mode to control per-route timeouts.
    • Introduced connect_first_available_with_deadline_owner and used it in tests.
    • Updated tests to wait for the hanging provider/link to start, then expire that route and select the Unix fallback; production still uses a single absolute tokio deadline.

Written for commit 9bce672. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 61dc37d4-42e2-4c00-bfd0-fa7c255a11d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit 6b4156a into feat-tui-iroh-ios Aug 11, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant