Repository navigation
Make initial route timeout tests owner-driven - #9993
Merged
lawrencecchen merged 1 commit intoAug 11, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for initial route fallback used the same 20 ms wall-clock deadline for the hanging route and the valid Unix fallback. Under Valgrind, the fallback also expired.
This change injects a test-only deadline owner. Each test waits for the hanging provider or link to start, expires only that route, and awaits Unix selection under one final watchdog. Production still uses one absolute Tokio deadline across provider and link setup.
Red evidence: https://github.com/manaflow-ai/cmux/actions/runs/31498625744
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Makes initial-route timeout tests owner-driven to fix Valgrind flakes. Tests now expire only the hanging route and reliably fall back to Unix, while production behavior stays the same.
InitialAttemptDeadlineOwnerwith a manual test mode to control per-route timeouts.connect_first_available_with_deadline_ownerand used it in tests.tokiodeadline.Written for commit 9bce672. Summary will update on new commits.