Repository navigation
fix(tui): flush local Windows SSH replies - #9955
Merged
lawrencecchen merged 4 commits intoAug 11, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…x-windows-ssh-local-flush
…ows-ssh-local-flush
…ows-ssh-local-flush
lawrencecchen
merged commit Aug 11, 2026
826f787
into
feat-tui-native-windows
38 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The SSH carrier is long-lived. The local bridge copied ssh.exe stdout into the local socket and flushed only after EOF, so socket clients timed out before replies became visible.
Proof
No local Cargo, Rust, Zig, or Xcode command was run.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Low Risk
Localized Windows SSH I/O change reusing an existing flush-per-chunk helper; no auth or data-model changes.
Overview
Fixes the local Windows SSH bridge so
ssh.exestdout is forwarded to the AF_UNIX client with per-chunk flush, not only after the stream ends.In
proxy_local_connection_over_ssh, download from OpenSSH stdout now usescopy_windows_carrier_downloadinstead ofio::copyplus a single end-of-stream flush—the same path already used for the remote relay and stdio carrier boundaries.Why: the SSH carrier stays open; buffering until EOF made local socket clients time out before replies appeared.
Reviewed by Cursor Bugbot for commit 60bc346. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Flush SSH stdout to the local Windows socket incrementally using the shared
copy_windows_carrier_download, aligning the local bridge with the remote relay behavior. Replies stream as they arrive instead of waiting for EOF, preventing client timeouts.io::copy+ manual flush withcopy_windows_carrier_downloadto write and flush each chunk.Written for commit aadf20e. Summary will update on new commits.