Repository navigation
Unify iOS shortcut strip background - #9859
Closed
azooz2003-bit wants to merge 7 commits into
Closed
azooz2003-bit wants to merge 7 commits into
azooz2003-bit wants to merge 7 commits into
Conversation
📝 WalkthroughWalkthroughThe accessory shortcut scroll view and stack now use transparent, non-opaque backgrounds. On iOS 26, accessory buttons use clear Liquid Glass configurations. An iOS test verifies the view configuration. ChangesAccessory toolbar rendering
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 23 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (23 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the iOS 26 light-mode background mismatch in the terminal shortcut strip.
The horizontal shortcut scroller now stays transparent and suppresses iOS 26 scroll-edge effects, so the pinned controls and scrolling controls share one continuous dock background.
Adds a runtime UIKit regression that verifies the scroller does not draw separate chrome.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Low Risk
Localized UIKit compositing and styling on the terminal input accessory bar; no input routing, networking, or auth changes.
Overview
Fixes a light-mode visual mismatch on iOS where the horizontally scrolling shortcut row looked like it had its own background, separate from the pinned keyboard/dismiss controls and the dock’s
backgroundView.The accessory toolbar’s
UIScrollViewand innerUIStackVieware now clear and non-opaque, with an inline note that UIKit can still composite an opaque stack inside a scroll view as a rectangular fill—so onlybackgroundViewshould own the bar color.Adds
accessoryShortcutScrollerDoesNotDrawSeparateChromeinGhosttySurfaceThemeTeststo assert those transparency settings at runtime.Reviewed by Cursor Bugbot for commit 55eb45e. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes the iOS 26 light‑mode background mismatch in the terminal shortcut strip. The scroller/stack stay transparent, edge effects are hidden, and iOS 26 buttons use clear glass so pinned and scrolling controls share one continuous dock background.
UIScrollViewand innerUIStackViewclear/non‑opaque and hid iOS 26 edge effects; added a UIKit test to assert transparency and no separate chrome..clearGlass()/.prominentClearGlass()to prevent a scroller‑wide backdrop and keep one dock background.Written for commit bfb3611. Summary will update on new commits.
Summary by CodeRabbit