Fix main compile break: classify() member access in CLI feed bridge - #9834
Merged
Merged
Conversation
#9804 landed `FeedEventClassifier.classify(...).0` while classify() already returned the named FeedEventClassification struct, so CLI/cmux.swift no longer compiles on main (every app-host and tests-build-and-lag CI job fails with "value of type 'FeedEventClassification' has no member '0'"). Use .hookEventName, matching the other call site. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CLI now extracts the hook event name through the returned value’s ChangesHook event handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
mainfails to compile: #9804 mergedFeedEventClassifier.classify(...).0afterclassify()had switched to returning the namedFeedEventClassificationstruct, so everyapp-host unit testsshard andtests-build-and-lagjob dies withCLI/cmux.swift:32779: value of type 'FeedEventClassification' has no member '0'(seen on merge-gate run https://github.com/manaflow-ai/cmux/actions/runs/31235977017, which gated #9779). The paused PR CI let the semantic conflict land silently.One line:
.0→.hookEventName, matching the struct field and the existing call site atCLI/cmux.swift:34954. No behavior change from what #9804 intended.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Cursor Bugbot is generating a summary for commit bf12119. Configure here.
Summary by cubic
Fixes a compile error on
mainby switching tuple access to a named property in the CLI feed event classification, restoring CI builds and tests.FeedEventClassifier.classify(...).0with.hookEventNameinCLI/cmux.swiftto matchFeedEventClassification. No behavior change.Written for commit bf12119. Summary will update on new commits.
Summary by CodeRabbit