Skip to content

Lay out standalone quit confirmation before display #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 2 commits into from
Aug 25, 2026
Merged

Lay out standalone quit confirmation before display #9620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533bbb4
Test standalone quit alert resolves lazy layout
austinywang Aug 5, 2026
c98c670
Lay out standalone quit alert before display
austinywang Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/QuitConfirmationAlertPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ final class QuitConfirmationAlertPresenter: NSObject, NSWindowDelegate {
}

private func presentStandalone() {
alert.layout()

let buttons = alert.buttons
if buttons.indices.contains(0) {
buttons[0].target = self
Expand Down
7 changes: 7 additions & 0 deletions cmuxTests/QuitConfirmationAlertPresenterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ struct QuitConfirmationAlertPresenterTests {
#expect(!alert.didRunModal)
#expect(completedResponse == nil)

// NSAlert starts with a lazy placeholder layout that stacks full-width
// buttons. The standalone presenter must resolve that layout before the
// alert becomes visible or the panel renders clipped and washed out.
let buttonFrames = alert.buttons.map(\.frame)
#expect(buttonFrames.count == 2)
#expect(abs(buttonFrames[0].midY - buttonFrames[1].midY) < 0.5)

alert.buttons[0].performClick(nil)

#expect(completedResponse == .alertFirstButtonReturn)
Expand Down