Repository navigation
Preserve exit status across bash prompt hooks - #9533
austinywang wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
_cmux_prompt_commandruns before downstreamPROMPT_COMMANDentriesFixes #5389
Testing
3c5b7bc22dfailed inValidate bash prompt hooks preserve command status: the downstream hook observed0, expected1.ee15d36fcfpassed the same shell-integration regression step../tests/test_issue_5389_bash_prompt_status.shpython3 tests/test_issue_5164_starship_prompt_composition.pybash -n Resources/shell-integration/cmux-bash-integration.bash tests/test_issue_5389_bash_prompt_status.sh./scripts/reload-cloud.sh --tag sym5389via Blacksmith macOS 26: build run 30884534432.workspace:1/surface:1through/tmp/cmux-debug-sym5389.sock, started interactive Bash, sourced the bundled integration, and put_cmux_prompt_commandbefore an observer in both array and stringPROMPT_COMMANDforms. Afterfalse, both observers printed status1. Quit the tagged app with the prescribedpkillcommand and removed its stale tagged socket.