Repository navigation
Fix tab drag reorder to middle positions - #9398
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe ChangesBonsplit submodule update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (24 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vendor/bonsplit`:
- Line 1: Update the vendor/bonsplit gitlink so its pinned commit is an ancestor
of origin/main, waiting for bonsplit PR `#197` to merge before selecting the
commit. Alternatively, point the dependency at a branch or tag that contains the
required changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a6d88acf-f422-411d-b193-94d40d04da57
📒 Files selected for processing (1)
vendor/bonsplit
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vendor/bonsplit`:
- Line 1: Do not merge this change while bonsplit PR `#197` remains open. After it
merges into main, repin the vendor/bonsplit gitlink to the resulting main
commit, or verify the current pinned commit is an ancestor of origin/main using
the provided validation flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: aed8adbf-2675-4758-a214-d7b1fe6b8988
📒 Files selected for processing (1)
vendor/bonsplit
| @@ -1 +1 @@ | |||
| Subproject commit e3837a787968d8235106d12418b653e8d1e2619c | |||
| Subproject commit 9b3e2ed6864c10b2fcc08b3b6970742de229dbbd | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Wait for bonsplit PR #197 to merge before pinning this gitlink.
As of August 3, 2026, PR #197 is still open and targets main. The main...9b3e2ed comparison contains 11 commits across 3 files, so this pointer still selects unmerged upstream history. (github.com)
Do not merge this cmux change yet. After PR #197 merges, repin vendor/bonsplit to the resulting main commit, or verify that this commit is an ancestor of origin/main.
#!/usr/bin/env bash
set -euo pipefail
path="vendor/bonsplit"
expected="$(git ls-tree HEAD -- "$path" | awk '{print $3}')"
git submodule update --init --checkout -- "$path"
git -C "$path" fetch --no-tags origin main
main_head="$(git -C "$path" rev-parse FETCH_HEAD)"
git -C "$path" merge-base --is-ancestor "$expected" "$main_head"
gh api repos/manaflow-ai/bonsplit/pulls/197 \
| jq -e '.state == "closed" and .merged_at != null and .base.ref == "main"'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@vendor/bonsplit` at line 1, Do not merge this change while bonsplit PR `#197`
remains open. After it merges into main, repin the vendor/bonsplit gitlink to
the resulting main commit, or verify the current pinned commit is an ancestor of
origin/main using the provided validation flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Dependency
Issues
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes tab drag reorder for middle drops by using
bonsplit’s manual drop target so tabs insert at the intended index. Updatesvendor/bonsplitto the latest merge fixes and adds UI tests that verify both later-to-middle and earlier-to-middle reorders.Bug Fixes
bonsplitmanual drop target for same-pane drops so middle drops go to the correct index.Tests
CMUX_UI_TEST_BONSPLIT_FOUR_TAB_SETUPand expose all tab titles and panel IDs for assertions.Written for commit a9f9e2a. Summary will update on new commits.
Summary by CodeRabbit