Skip to content

Add group-scoped workspace cycle actions - #9352

Merged
austinywang merged 4 commits into
mainfrom
feat-9137-group-scoped-workspace-cycle
Aug 11, 2026
Merged

austinywang merged 4 commits into
mainfrom
feat-9137-group-scoped-workspace-cycle

Conversation

@austinywang

@austinywang austinywang commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Closes #9137.

Summary

  • Adds independently bindable nextSidebarTabInGroup and prevSidebarTabInGroup actions.
  • Keeps existing Next/Previous Workspace actions window-wide.
  • Resolves cycle destinations in the CmuxWorkspaces state model and runs every cycle through one TabManager selection path.
  • Exposes both actions in Keyboard Shortcut Settings, cmux.json schema, and English/Japanese documentation.

Behavior

  • Group-scoped cycling wraps through non-anchor members in sidebar order.
  • Starting from the group anchor enters at the first/last member based on direction.
  • An ungrouped focused workspace falls back to window-wide cycling.
  • A group with no non-anchor member is a no-op.

Coverage

  • App-level configured-shortcut routing regression coverage.
  • Pure CmuxWorkspaces destination-policy coverage for both directions, anchor skipping, wraparound, ungrouped fallback, empty groups, and unchanged flat cycling.
  • English and Japanese localization entries and shortcut documentation.

Note

Low Risk
Navigation and shortcut wiring only; existing window-wide shortcuts keep default behavior via .window scope.

Overview
Adds Next/Previous Workspace in Group shortcut actions (unbound by default) alongside the existing window-wide workspace cycling. TabManager now routes all next/prev workspace selection through a shared cycleWorkspace path that asks WorkspacesModel for a destination via new cycleDestination APIs with WorkspaceCycleScope (window vs focusedGroupMembers).

Group-scoped cycling wraps through non-anchor members in sidebar order, enters from the anchor at the first/last member, falls back to window-wide order when focus is ungrouped, and no-ops when a group has no members. Settings, dock routing, schema, web shortcut data, and EN/JA strings document the new actions; tests cover model policy and app-level shortcut routing. RestoredPanelTitleBoundaryTests is refactored for clearer intermediate expectations (no behavior change).

Reviewed by Cursor Bugbot for commit d97ba24. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@austinywang, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e28cc9f5-8d7b-4689-8b93-5dd08caa55ce

📥 Commits

Reviewing files that changed from the base of the PR and between f9a29b4 and d97ba24.

📒 Files selected for processing (19)
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction+Defaults.swift
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction+DisplayName.swift
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction+Group.swift
  • Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/ShortcutAction.swift
  • Packages/macOS/CmuxWorkspaces/Sources/CmuxWorkspaces/Model/WorkspacesModel+Cycling.swift
  • Packages/macOS/CmuxWorkspaces/Sources/CmuxWorkspaces/Values/WorkspaceCycleDirection.swift
  • Packages/macOS/CmuxWorkspaces/Sources/CmuxWorkspaces/Values/WorkspaceCycleScope.swift
  • Packages/macOS/CmuxWorkspaces/Tests/CmuxWorkspacesTests/Session/RestoredPanelTitleBoundaryTests.swift
  • Packages/macOS/CmuxWorkspaces/Tests/CmuxWorkspacesTests/WorkspaceCycleDestinationTests.swift
  • Resources/Localizable.xcstrings
  • Sources/AppDelegate+DockShortcutRouting.swift
  • Sources/AppDelegate.swift
  • Sources/KeyboardShortcutSettings.swift
  • Sources/TabManager.swift
  • cmux.xcodeproj/project.pbxproj
  • cmuxTests/WorkspaceGroupCycleShortcutTests.swift
  • skills/cmux-settings/references/shortcut-actions.md
  • web/data/cmux-shortcuts.ts
  • web/data/cmux.schema.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinywang
austinywang marked this pull request as ready for review August 1, 2026 05:01
@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@austinywang austinywang closed this Aug 1, 2026
@austinywang austinywang reopened this Aug 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@austinywang
austinywang merged commit 2505c9b into main Aug 11, 2026
37 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: scope Next/Previous Workspace to the focused workspace group

1 participant