Skip to content

Unbreak workflow-guard-tests: fake iOS archives need dSYMs and Symbols #9279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azooz2003-bit merged 1 commit into from
Jul 31, 2026
Merged

Unbreak workflow-guard-tests: fake iOS archives need dSYMs and Symbols #9279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_ios_appstore_lane_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ def setting(prefix):
"CMUXCrashReportingEnabled": crash_reporting_enabled,
}},
)
# upload-testflight.sh refuses archives without dSYM bundles.
(archive / "dSYMs" / "cmux.app.dSYM" / "Contents").mkdir(parents=True, exist_ok=True)
sys.exit(0)

if "-exportArchive" in args:
Expand All @@ -343,11 +345,17 @@ def setting(prefix):
)
profile_marker = "beta profile" if bundle_id == BETA_BUNDLE_ID else "fake profile"
(app / "embedded.mobileprovision").write_text(profile_marker, encoding="utf-8")
# upload-testflight.sh refuses IPAs without Symbols/*.symbols.
symbols_root = export_path / "Symbols"
symbols_root.mkdir(parents=True, exist_ok=True)
(symbols_root / "cmux.symbols").write_text("fake symbols", encoding="utf-8")
ipa = export_path / "cmux.ipa"
ipa.parent.mkdir(parents=True, exist_ok=True)
with zipfile.ZipFile(ipa, "w") as zf:
for item in payload_root.rglob("*"):
zf.write(item, item.relative_to(export_path))
for item in symbols_root.rglob("*"):
zf.write(item, item.relative_to(export_path))
sys.exit(0)

sys.exit(0)
Expand Down Expand Up @@ -517,6 +525,8 @@ def _write_fake_archive(path: Path, *, bundle_id: str, build_number: str, market
}
(path).mkdir(parents=True, exist_ok=True)
app.mkdir(parents=True, exist_ok=True)
# upload-testflight.sh refuses archives without dSYM bundles.
(path / "dSYMs" / "cmux.app.dSYM" / "Contents").mkdir(parents=True, exist_ok=True)
(path / "Info.plist").write_bytes(
_plist_bytes(
{
Expand Down