Repository navigation
Fix detached transfer test fixture - #9216
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test helper now supplies ChangesTransfer test update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
managedAgentResumeBindingargument in the dormant detached-transfer test fixtureAppDelegateEqualizeSplitsShortcutTests.swiftRoot cause
PR #9091 added
managedAgentResumeBindingtoWorkspace.DetachedSurfaceTransfer, but one test-only initializer call was not updated. Full CI was hidden by the workflow guard outage, so the missing argument was not visible before merge.Verification
dc948fba79a67bfb719d6d4a12a0809e086ce61bmainCI will be dispatched after mergeFollow-up for the compile failures exposed by #9209.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fix detached transfer test fixture by passing the new
managedAgentResumeBindingargument. Restores compilation for AppDelegateEqualizeSplitsShortcutTests.swift.managedAgentResumeBinding: nilto the test-onlyDetachedSurfaceTransferinitializer to match current API.Written for commit 771b92b. Summary will update on new commits.
Summary by CodeRabbit