Skip to content

Fix detached transfer test fixture - #9216

Merged
austinywang merged 1 commit into
mainfrom
hotfix-detached-transfer-test-fixture
Jul 30, 2026
Merged

austinywang merged 1 commit into
mainfrom
hotfix-detached-transfer-test-fixture

Conversation

@austinywang

@austinywang austinywang commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • pass the new managedAgentResumeBinding argument in the dormant detached-transfer test fixture
  • restore compilation of AppDelegateEqualizeSplitsShortcutTests.swift

Root cause

PR #9091 added managedAgentResumeBinding to Workspace.DetachedSurfaceTransfer, but one test-only initializer call was not updated. Full CI was hidden by the workflow guard outage, so the missing argument was not visible before merge.

Verification

  • exact one-line correction already authored in commit dc948fba79a67bfb719d6d4a12a0809e086ce61b
  • one test-only Swift file changes
  • no runtime behavior or Swift budget TSV changes
  • final main CI will be dispatched after merge

Follow-up for the compile failures exposed by #9209.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fix detached transfer test fixture by passing the new managedAgentResumeBinding argument. Restores compilation for AppDelegateEqualizeSplitsShortcutTests.swift.

  • Bug Fixes
    • Add managedAgentResumeBinding: nil to the test-only DetachedSurfaceTransfer initializer to match current API.
    • Test-only change; no runtime behavior or performance impact.

Written for commit 771b92b. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Fixed terminal transfer handling to remain compatible with updated transfer requirements.
    • No user-facing behavior changes are expected.

@austinywang
austinywang merged commit 1381129 into main Jul 30, 2026
3 checks passed
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1ddc5373-1f2b-4bb9-8b39-24087ee81a5d

📥 Commits

Reviewing files that changed from the base of the PR and between 6ab4595 and 771b92b.

📒 Files selected for processing (1)
  • cmuxTests/AppDelegateEqualizeSplitsShortcutTests.swift

📝 Walkthrough

Walkthrough

The test helper now supplies managedAgentResumeBinding: nil when constructing Workspace.DetachedSurfaceTransfer, matching the updated initializer.

Changes

Transfer test update

Layer / File(s) Summary
Dormant transfer initializer
cmuxTests/AppDelegateEqualizeSplitsShortcutTests.swift
makeDormantTerminalTransfer includes a nil managed agent resume binding in the detached surface transfer construction.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: lawrencecchen

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix-detached-transfer-test-fixture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant