Skip to content

Exempt quoted script-path strings from Ghostty Zig workflow guard #9201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azooz2003-bit wants to merge 2 commits into from
Closed

Exempt quoted script-path strings from Ghostty Zig workflow guard #9201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f394a
Exempt quoted script-path strings from Ghostty Zig workflow guard
azooz2003-bit Jul 30, 2026
359aba0
Allowlist sleep-then-assert findings that landed via #8931 and #9163
azooz2003-bit Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/test-determinism-allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# Format: relpath<TAB>rule<TAB>short reason
# A finding whose (path, rule) appears here is suppressed.
# Remove a line once the underlying test is determinized.
cmuxTests/WorkspaceForkConversationContextMenuTests.swift assert-on-duration grandfathered
cmuxTests/WorkspaceForkConversationContextMenuTests.swift sleep-then-assert grandfathered
Packages/iOS/CmuxMobileRPC/Tests/CmuxMobileRPCTests/MobileCoreRPCTransportDrainTests.swift sleep-then-assert landed via https://github.com/manaflow-ai/cmux/pull/8931; determinize then remove
Packages/iOS/CmuxMobileShellUI/Tests/CmuxMobileShellUITests/OnboardingMacDiscoveryKeepAliveTests.swift sleep-then-assert landed via https://github.com/manaflow-ai/cmux/pull/9163; determinize then remove
5 changes: 5 additions & 0 deletions tests/check_ghostty_zig_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def workflow_failures(workflow_dir: Path) -> list[str]:
stripped = line.strip()
if stripped.startswith("#") or stripped.startswith(("- \"scripts/", "- 'scripts/")):
continue
# A line that is nothing but a quoted script path (optionally with a
# trailing comma) names the script without executing it, e.g. a JS
# path array used for change detection inside a github-script step.
if re.fullmatch(r"""(["'])scripts/[^"']+\1,?""", stripped):
continue
if not any(name in line for name in CONSUMER_NAMES):
continue
if current_job is None:
Expand Down