Skip to content

Fix CmuxMobileShellUI build break from PR 9146 merge - #9195

Merged
azooz2003-bit merged 1 commit into
mainfrom
fix-ios-shellui-verified-replay-return
Jul 30, 2026
Merged

azooz2003-bit merged 1 commit into
mainfrom
fix-ios-shellui-verified-replay-return

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Jul 30, 2026 •

Copy link
Copy Markdown
Collaborator

#9146 merged with a conflict resolution that left one bare return in the now-Bool-returning verified-replay cancellation guard (applyVerifiedRenderGrid anchor-capture path), breaking the iOS app build in CmuxMobileShellUI. One-line fix: return false on cancellation, matching the other guards. Verified locally: tagged iOS simulator build of the same tree succeeds with this change and fails without it.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the iOS build break in CmuxMobileShellUI by replacing a bare return with return false in the verified-replay cancellation guard within the anchor-capture path of applyVerifiedRenderGrid. iOS simulator build now succeeds.

Written for commit 6541117. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved cancellation handling during verified replay rendering so cancelled operations consistently report that they were not applied.

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@azooz2003-bit
azooz2003-bit merged commit b2734c7 into main Jul 30, 2026
5 of 6 checks passed
@azooz2003-bit
azooz2003-bit deleted the fix-ios-shellui-verified-replay-return branch July 30, 2026 01:12
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a1c14092-671e-40d8-95f7-f31b6a9f4153

📥 Commits

Reviewing files that changed from the base of the PR and between 37c267a and 6541117.

📒 Files selected for processing (1)
  • Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/GhosttySurfaceRepresentable.swift

📝 Walkthrough

Walkthrough

The verified replay render-grid application now returns false when cancellation is detected after capturing the viewport anchor.

Changes

Verified replay application

Layer / File(s) Summary
Explicit cancellation result
Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/GhosttySurfaceRepresentable.swift
applyThemeMatchedVerifiedRenderGrid reports that the application was not completed when the task is cancelled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: lawrencecchen

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ios-shellui-verified-replay-return

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

azooz2003-bit added a commit that referenced this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant