Conversation
📝 WalkthroughWalkthroughAdds Gajae Code ( ChangesGajae Code support
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GajaeCodeExtension
participant CmuxCLI
participant HookSessionStore
participant SurfaceBinding
GajaeCodeExtension->>CmuxCLI: Forward session lifecycle event
CmuxCLI->>HookSessionStore: Accept session and retire previous record
CmuxCLI->>SurfaceBinding: Set restore binding
SurfaceBinding-->>GajaeCodeExtension: Retain launch and tmux metadata
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (23 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CLI/cmux.swift`:
- Around line 30827-30845: Replace the lookup-then-consume sequence in the
gajae-code handling block with an atomic store helper that, within one locked
transaction, verifies the current previous session’s workspaceId and surfaceId
before removing it. Add the helper near the existing session-store methods, have
it no-op when either binding no longer matches, and invoke it using
previousSessionId, workspaceId, and surfaceId.
In `@CLI/CMUXCLI`+GajaeCodeExtension.swift:
- Around line 267-272: Update the config-root construction near
nonEmptyGajaeCodeEnvironmentValue for GJC_CONFIG_DIR to detect whether configDir
is absolute; use it directly when absolute, otherwise append it to home,
matching the existing GJC_CODING_AGENT_DIR behavior. Keep the subsequent agent
URL construction unchanged.
- Around line 315-321: Add localized `cli.hooks.gajaeCode.*` entries to
`Resources/Localizable.xcstrings` for every supported catalog locale, including
`zh-Hant`, `zh-Hans`, and all existing non-English locales. Cover the keys used
by the Gajae Code hook messages, preserving the existing English and Japanese
translations and matching the catalog’s established localization structure.
- Around line 71-73: Update the tmux argument check in the
GJC_TMUX_ACTIVE_SESSION handling to recognize both the exact --tmux token and
arguments beginning with --tmux=. Only append the bare --tmux flag when no
tmux-form argument is already present, preserving the existing argv behavior
otherwise.
- Around line 216-229: Update sendHook to return whether the hook was
successfully delivered, including false for spawn, stdin, and timeout failures.
In bindCurrentSession, retain the current activeSessionId until sendHook reports
success, then commit nextSessionId; preserve the previous_session_id payload so
failed retire attempts can be retried with the original session identifier.
- Around line 100-103: Update isRootSession to require an explicit root
indicator from ctx.sessionMetadata, such as kind === "root", and ensure missing
sessionMetadata or kind does not qualify as a root session. Preserve the
existing worker-environment exclusion before applying this authoritative
metadata check.
In
`@Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift`:
- Around line 294-310: The booleanOptions list in
AgentLaunchSanitizerPrimaryPolicies must no longer treat --default as a restored
Gajae Code argument. Remove --default from booleanOptions, add it to
droppedOptions, and add a regression assertion confirming restored argv omits
--default while preserving the remaining options.
In `@tests/test_gajae_code_extension_install.py`:
- Around line 354-361: Replace the fixed time.sleep(0.3) in the invocation-count
check with a deterministic completion signal. Update the fake bun script flow to
emit a sentinel invocation after all sub-session and team-worker calls, wait for
that sentinel through the existing wait_for_text mechanism, then assert the
non-empty invocation count remains exactly expected_invocations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 930b0088-42d8-44c6-9134-9d793f222ade
📒 Files selected for processing (19)
.github/workflows/ci.ymlCLI/CMUXCLI+AgentHookCatalog.swiftCLI/CMUXCLI+GajaeCodeExtension.swiftCLI/cmux.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchCaptureTrust.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchEnvironmentPolicy.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizer.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentResumeArgv.swiftPackages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/AgentLaunchCaptureTrustTests.swiftPackages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/AgentLaunchEnvironmentPolicyTests.swiftPackages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/AgentLaunchSanitizerTests.swiftPackages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/AgentResumeArgvTests.swiftResources/Localizable.xcstringsSources/CmuxTaskManagerCodingAgentDefinition+BuiltIns.swiftcmux.xcodeproj/project.pbxprojcmuxTests/TaskManagerResourcesTests.swiftdocs/agent-hooks.mdtests/test_gajae_code_extension_install.py
| if (firstString(process.env.GJC_TMUX_ACTIVE_SESSION) && !argv.includes("--tmux")) { | ||
| argv.push("--tmux"); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
--tmux dedupe misses the --tmux=<value> form.
argv.includes("--tmux") only matches the exact token, so an original launch using --tmux=name gets a second, bare --tmux appended into the persisted resume argv. Match by prefix instead.
🐛 Proposed fix
- if (firstString(process.env.GJC_TMUX_ACTIVE_SESSION) && !argv.includes("--tmux")) {
+ const hasTmuxFlag = argv.some((value) => value === "--tmux" || value.startsWith("--tmux="));
+ if (firstString(process.env.GJC_TMUX_ACTIVE_SESSION) && !hasTmuxFlag) {
argv.push("--tmux");
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (firstString(process.env.GJC_TMUX_ACTIVE_SESSION) && !argv.includes("--tmux")) { | |
| argv.push("--tmux"); | |
| } | |
| const hasTmuxFlag = argv.some((value) => value === "--tmux" || value.startsWith("--tmux=")); | |
| if (firstString(process.env.GJC_TMUX_ACTIVE_SESSION) && !hasTmuxFlag) { | |
| argv.push("--tmux"); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLI/CMUXCLI`+GajaeCodeExtension.swift around lines 71 - 73, Update the tmux
argument check in the GJC_TMUX_ACTIVE_SESSION handling to recognize both the
exact --tmux token and arguments beginning with --tmux=. Only append the bare
--tmux flag when no tmux-form argument is already present, preserving the
existing argv behavior otherwise.
| function isRootSession(ctx: ExtensionContext): boolean { | ||
| if (firstString(process.env.GJC_TEAM_WORKER, process.env.GJC_TEAM_INTERNAL_WORKER)) return false; | ||
| return ctx.sessionMetadata?.kind !== "sub"; | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
@gajae-code/coding-agent ExtensionContext sessionMetadata kind sub session
💡 Result:
In the context of the @gajae-code/coding-agent package, there is no standardized, public-facing API or configuration property strictly named "ExtensionContext sessionMetadata kind sub session". The terms you are referencing appear to be a mixture of internal concepts from the Gajae Code codebase and unrelated VS Code platform definitions: 1. Gajae Code Concepts: The project uses an SDK-based session system (accessible via packages/coding-agent/src/sdk/session.ts) [1][2]. It supports "subagents" for specialized task delegation [3] and provides a harness for managing agent sessions, often using custom plugin skills like gjc-session to manage worktree-backed sessions [4][5]. However, the specific string "ExtensionContext sessionMetadata kind sub session" is not a recognized configuration or API path in the Gajae Code documentation or public codebase [6][7]. 2. VS Code Concepts: The terminology closely resembles recent internal work within the VS Code platform (specifically the Agent Host integration), which includes managing "session metadata" [8][9], "custom agents" [10][11], and "session summaries" [12][9]. The VS Code API distinguishes between various session states and metadata types (e.g., IAgentSessionMetadata, SessionSummary), but "kind" and "sub session" are not standard top-level properties in that documented schema [10][8]. If you are encountering this string in an error log or code snippet, it is likely an internal debugging label, a custom key-value pair used by a specific extension, or a misconfiguration within an implementation of the Gajae Code harness or a VS Code Agent Host provider [6][8]. For managing sessions in Gajae Code, refer to the documented SDK methods for creating and controlling sessions (e.g., createAgentSession) rather than attempting to manipulate internal metadata structures directly [1][2].
Citations:
- 1: https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/master/docs/codebase-overview.md
- 2: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
- 3: Yeachan-Heo/gajae-code@627328f
- 4: https://gajae-code.com/docs/getting-started.html
- 5: https://gajae-code.com/docs/harness.html
- 6: https://github.com/Yeachan-Heo/gajae-code
- 7: https://gajae-code.com/docs/index.html
- 8: Add agent session project metadata microsoft/vscode#309114
- 9: https://github.com/microsoft/vscode/blob/e8db8ed8/src/vs/platform/agentHost/node/agentHostStateManager.ts
- 10: microsoft/vscode@35d33ab
- 11: feat: Enhance agent host session management with custom agent support microsoft/vscode#317398
- 12: agentHost: make the orchestrator own sessions; providers keep exact chat bindings microsoft/vscode#326620
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== locate CLI file and package references =="
fd -a 'CMUXCLI+GajaeCodeExtension.swift|package.json|Package.swift|Info.plist|README.*' . | sed 's#^\./##' | head -100
echo
echo "== relevant Swift file outline/lines =="
FILE="$(fd 'CMUXCLI+GajaeCodeExtension.swift' . | head -1)"
if [ -n "${FILE:-}" ]; then
echo "FILE=$FILE"
wc -l "$FILE"
sed -n '1,180p' "$FILE" | cat -n
fi
echo
echo "== search session metadata / allowed versions =="
rg -n "sessionMetadata|GJC_TEAM_WORKER|GJC_TEAM_INTERNAL_WORKER|Gj[aA]e|0\.10\.0|0\.11\.11|rootSession|isRootSession|kind" -S --glob '!node_modules' --glob '!build' --glob '!Dist' .Repository: manaflow-ai/cmux
Length of output: 50373
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== git status/stat =="
git status --short 2>/dev/null || true
git diff --stat 2>/dev/null || true
echo
echo "== candidate Swift files =="
git ls-files '*.swift' | rg 'CLI/CMUXCLI|Gajae|Extension' || true
echo
echo "== exact relevant Swift file =="
FILE="$(git ls-files | rg '(^|/)CMUXCLI+GajaeCodeExtension\.swift$' | head -1)"
if [ -n "${FILE:-}" ]; then
echo "FILE=$FILE"
wc -l "$FILE"
sed -n '1,220p' "$FILE" | cat -n
fi
echo
echo "== focused searches =="
rg -n "isRootSession|sessionMetadata|GJC_TEAM_WORKER|GJC_TEAM_INTERNAL_WORKER|kind" . --glob '!node_modules' --glob '!build' --glob '!Dist' --glob '!*.png' --glob '!*.jpg' --glob '!*.jpeg' --max-count 80 || true
echo
echo "== dependency/version references for gajae/coding-agent =="
git ls-files | rg '(^|/)(package\.json|Package\.swift|.*gajae.*|.*coding-agent.*)' | head -100 | while read -r f; do
echo "--- $f"
rg -n "`@gajae`|coding-agent|Gajae|GJC|@.*gajae" "$f" -C 3 || true
doneRepository: manaflow-ai/cmux
Length of output: 8374
🌐 Web query:
github Yeachan-Heo gajae-code "ExtensionContext" "sessionMetadata"
💡 Result:
The terms Yeachan-Heo, gajae-code, ExtensionContext, and sessionMetadata belong to two distinct development ecosystems and are not directly related [1][2][3]. 1. Yeachan-Heo / gajae-code: This is an independent open-source project managed by Yeachan-Heo [1][4]. Gajae-Code (gjc) is a focused AI coding agent and harness designed to be repository-native, utilizing tmux and Git worktrees for isolated execution [1][5]. It explicitly positions itself as an external coding-agent harness that does not install into or replace existing IDE extensions like Claude Code or Claw Code [1]. It utilizes its own SDK, WebSocket-based loopback protocols, and Coordinator MCP (Model Context Protocol) to facilitate external control and automation, rather than relying on standard IDE extension APIs [1][6][7]. 2. ExtensionContext and sessionMetadata: These terms are standard components of the VS Code Extension API and Microsoft's Copilot Chat architecture [2][3][8]. ExtensionContext: A standard VS Code API object passed to extensions to manage lifecycle, storage, and subscriptions [3]. sessionMetadata: A data structure used within VS Code's internal Copilot Chat and GitHub Pull Request extensions to manage chat session states, workspace context, and pull request information [2][3][9]. There is no functional or technical overlap between the gajae-code project's architecture and the VS Code Extension API's session metadata management [1][6][2]. Any perceived connection is likely an artifact of searching codebases that share common TypeScript/Node.js terminology [7][2][8].
Citations:
- 1: https://github.com/Yeachan-Heo/gajae-code
- 2: https://github.com/microsoft/vscode-copilot-chat/blob/main/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts
- 3: https://github.com/microsoft/vscode-pull-request-github/blob/main/src/commands.ts
- 4: https://github.com/Yeachan-Heo
- 5: https://trendshift.io/repositories/40577
- 6: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/bot-integration.md
- 7: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
- 8: https://github.com/microsoft/vscode/blob/e8db8ed8/extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts
- 9: https://github.com/microsoft/vscode/blob/99489178/extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts
🌐 Web query:
github Yeachan-Heo gajae-code "kind" "sub" sessionMetadata
💡 Result:
In the context of the Yeachan-Heo/gajae-code repository, sessionMetadata.kind === "sub" refers to in-process sub-agent sessions [1][2]. Gajae-Code is an experimental coding-agent harness that supports structured workflows and team-based execution [3][4]. When the system spawns child sessions (for example, to handle parallel tasks or delegated sub-agent work), it classifies them as "sub" sessions [1][2]. These sub-sessions are often excluded from certain primary session notifications or forum topic generation to avoid clutter and maintain focus on the root session [1][2]. The sessionMetadata object is part of the internal architecture used by the coding agent to track session types, hierarchy, and state, ensuring that the system can distinguish between primary user-driven sessions and automated in-process sub-agents [5][1].
Citations:
- 1: Telegram topics: option to suppress forum topics for GJC-spawned child sessions (keep explicit /session_create bidirectional) Yeachan-Heo/gajae-code#1908
- 2: Telegram topics: orphaned topics accumulate forever; every spawned child session creates its own topic; fixed naming buries session titles; user renames are clobbered Yeachan-Heo/gajae-code#1901
- 3: https://github.com/Yeachan-Heo/gajae-code
- 4: https://trendshift.io/repositories/40577
- 5: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
🌐 Web query:
Yeachan-Heo gajae-code "GJC_TEAM_WORKER" "GJC_TEAM_INTERNAL_WORKER"
💡 Result:
Gajae-Code (gjc) is an open-source, experimental coding-agent harness developed by Yeachan-Heo [1][2]. It is designed to provide structured planning, persistent evidence, and tmux-backed, multi-worker execution for software development tasks [1][3]. The terms GJC_TEAM_WORKER and GJC_TEAM_INTERNAL_WORKER (or similar environment-level configurations like GJC_TEAM_WORKER_COMMAND, GJC_TEAM_WORKER_CLI, and GJC_TEAM_WORKER_ID) are part of the internal orchestration system within Gajae-Code, specifically related to the gjc team command [4][5]. Key technical aspects include: 1. Team Orchestration: The gjc team functionality allows for multi-worker coordination within a tmux environment [3][5]. When a team session is launched, it splits the current tmux leader window into multiple panes to run individual agent workers [4][3]. 2. Environment Configuration: - GJC_TEAM_WORKER: Used to identify specific workers, typically formatted as team_name/worker_id [6]. - GJC_TEAM_WORKER_COMMAND: Defines the command used to launch individual agent workers within the team session [4][5]. - GJC_TEAM_WORKER_CLI / GJC_TEAM_WORKER_CLI_MAP: Configure which CLI tool (e.g., gjc or other compatible workers) is used for the agent workers [4]. 3. State and Lifecycle: The system relies on configuration files and state directories under.gjc/ (e.g.,.gjc/state/team) to manage task claims, worker heartbeats, and team metadata [4][5]. The architecture supports isolated worktrees for individual workers, allowing them to operate concurrently on different parts of a project [7]. For detailed usage, architecture, and developer documentation, you can refer to the official repository at github.com/Yeachan-Heo/gajae-code [1][8].
Citations:
- 1: https://github.com/Yeachan-Heo/gajae-code
- 2: https://github.com/Yeachan-Heo/gajae-code
- 3: Restore GJC team multi-worker parity Yeachan-Heo/gajae-code#41
- 4: Yeachan-Heo/gajae-code@e3e0583
- 5: Yeachan-Heo/gajae-code@7a841f4
- 6: Yeachan-Heo/gajae-code@87bd15e
- 7: Yeachan-Heo/gajae-code@4c0a4e9
- 8: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
Gate isRootSession on an explicit root indicator.
ctx.sessionMetadata?.kind !== "sub" treats missing metadata as root, so if sessionMetadata/kind is absent on any supported GJC version, a real sub-session can bind the leader surface. Use kind === "root" or reject missing metadata; only fall back when the metadata source is guaranteed and the failure mode is non-authoritative.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLI/CMUXCLI`+GajaeCodeExtension.swift around lines 100 - 103, Update
isRootSession to require an explicit root indicator from ctx.sessionMetadata,
such as kind === "root", and ensure missing sessionMetadata or kind does not
qualify as a root session. Preserve the existing worker-environment exclusion
before applying this authoritative metadata check.
Source: Path instructions
| let home = nonEmptyGajaeCodeEnvironmentValue("HOME", in: environment) ?? NSHomeDirectory() | ||
| let configDir = nonEmptyGajaeCodeEnvironmentValue("GJC_CONFIG_DIR", in: environment) ?? ".gjc" | ||
| let configRoot = (home as NSString).appendingPathComponent(configDir) | ||
| return URL(fileURLWithPath: configRoot, isDirectory: true) | ||
| .appendingPathComponent("agent", isDirectory: true) | ||
| .standardizedFileURL |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Absolute GJC_CONFIG_DIR is joined onto HOME.
(home as NSString).appendingPathComponent(configDir) produces $HOME/abs/path when GJC_CONFIG_DIR is an absolute path, installing the extension outside the real agent directory. GJC_CODING_AGENT_DIR already handles this case; apply the same check here.
🐛 Proposed fix
let configDir = nonEmptyGajaeCodeEnvironmentValue("GJC_CONFIG_DIR", in: environment) ?? ".gjc"
- let configRoot = (home as NSString).appendingPathComponent(configDir)
+ let configRoot = (configDir as NSString).isAbsolutePath
+ ? configDir
+ : (home as NSString).appendingPathComponent(configDir)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let home = nonEmptyGajaeCodeEnvironmentValue("HOME", in: environment) ?? NSHomeDirectory() | |
| let configDir = nonEmptyGajaeCodeEnvironmentValue("GJC_CONFIG_DIR", in: environment) ?? ".gjc" | |
| let configRoot = (home as NSString).appendingPathComponent(configDir) | |
| return URL(fileURLWithPath: configRoot, isDirectory: true) | |
| .appendingPathComponent("agent", isDirectory: true) | |
| .standardizedFileURL | |
| let home = nonEmptyGajaeCodeEnvironmentValue("HOME", in: environment) ?? NSHomeDirectory() | |
| let configDir = nonEmptyGajaeCodeEnvironmentValue("GJC_CONFIG_DIR", in: environment) ?? ".gjc" | |
| let configRoot = (configDir as NSString).isAbsolutePath | |
| ? configDir | |
| : (home as NSString).appendingPathComponent(configDir) | |
| return URL(fileURLWithPath: configRoot, isDirectory: true) | |
| .appendingPathComponent("agent", isDirectory: true) | |
| .standardizedFileURL |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLI/CMUXCLI`+GajaeCodeExtension.swift around lines 267 - 272, Update the
config-root construction near nonEmptyGajaeCodeEnvironmentValue for
GJC_CONFIG_DIR to detect whether configDir is absolute; use it directly when
absolute, otherwise append it to home, matching the existing
GJC_CODING_AGENT_DIR behavior. Keep the subsequent agent URL construction
unchanged.
| booleanOptions: [ | ||
| "--allow-home", | ||
| "--continue", | ||
| "--default", | ||
| "--no-lsp", | ||
| "--no-pty", | ||
| "--no-rules", | ||
| "--no-session", | ||
| "--no-title", | ||
| "--no-tools", | ||
| "--print", | ||
| "--tmux", | ||
| "-c", | ||
| "-h", | ||
| "-p", | ||
| "-v" | ||
| ], |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Files:"
git ls-files | rg 'AgentLaunchSanitizerPrimaryPolicies\.swift|CMAgent|Launch|Sanitizer|restore|default|mpreset' || true
echo
echo "Target excerpt:"
file="$(git ls-files | rg 'AgentLaunchSanitizerPrimaryPolicies\.swift$' | head -n1)"
if [ -n "$file" ]; then
wc -l "$file"
ast-grep outline "$file" --view compact || true
sed -n '240,340p' "$file" | nl -ba -v240
fi
echo
echo "Search policy constants/usages:"
rg -n "booleanOptions|droppedOptions|--default|mpreset|sanitize|Restore|restore" -S . --glob '!node_modules' --glob '!build' --glob '!DerivedData' | head -n 200Repository: manaflow-ai/cmux
Length of output: 10918
🌐 Web query:
Yeachan-Heo gajae-code packages/coding-agent/src/cli.ts --default --mpreset documentation
💡 Result:
The command you referenced relates to the Gajae-Code (gjc) project, an experimental coding-agent harness developed by Yeachan-Heo [1][2]. The command bun packages/coding-agent/src/cli.ts --default --mpreset documentation is a way to execute the agent's CLI directly from source using the Bun runtime, specifically configured to use a "documentation" preset [1][3]. Gajae-Code is designed as an external coding-agent harness that provides a focused workflow for tasks like interviews, plan reviews, and tmux-native execution [1][2]. By running packages/coding-agent/src/cli.ts from source, users can bypass the compiled binary version to access the latest development features and settings [4][3]. Key components of this command include: - bun: The JavaScript runtime used to execute the TypeScript CLI file [3]. - packages/coding-agent/src/cli.ts: The source entry point for the coding-agent CLI [3][5]. - --default: Typically signals the use of default configurations or a default startup mode [6][7]. - --mpreset documentation: This argument selects a specific model preset (or "mode preset") optimized for documentation tasks [8]. For further details on command arguments, environment variables, and workflow configurations, consult the documentation within the repository, such as docs/environment-variables.md or the main README.md file [7][2]. Gajae-Code remains in beta, and users are encouraged to verify outputs before applying them to critical workflows [1][2].
Citations:
- 1: https://github.com/Yeachan-Heo/gajae-code
- 2: https://github.com/Yeachan-Heo/gajae-code/blob/main/README.md
- 3: https://github.com/JEO-tech-ai/gajae-code
- 4: Post-merge dogfood: coding-agent typecheck and compiled gjc native loading fail Yeachan-Heo/gajae-code#264
- 5: https://ithub.global.ssl.fastly.net/Yeachan-Heo/gajae-code/actions/runs/28350995285/workflow
- 6: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
- 7: Yeachan-Heo/gajae-code@7f27509
- 8: https://github.com/Yeachan-Heo/gajae-code/releases
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift"
echo "Target lines:"
awk 'NR>=260 && NR<=325 { printf "%6d %s\n", NR, $0 }' "$file"
echo
echo "Relevant sanitizer definitions/usages:"
rg -n "static let .*booleanOptions|static let .*droppedOptions|booleanOptions|droppedOptions|sanitize|AgentLaunchSanitizerPrimaryPolicies|PrimaryPolicies" Packages/macOS/CMUXAgentLaunch/Sources Packages/macOS/CMUXAgentLaunch/Tests -S
echo
echo "Gajae cli snippets from known github blob if network available:"
python3 - <<'PY'
import urllib.request
urls = [
"https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/main/packages/coding-agent/src/cli.ts",
"https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/main/packages/coding-agent/src/cli.js",
]
for url in urls:
try:
text=urllib.request.urlopen(url, timeout=15).read().decode("utf-8", "replace")
print(f"\n--- {url} ---")
for i,line in enumerate(text.splitlines(), 1):
if "default" in line or "mpreset" in line or "Set as default" in line or "persist" in line:
if i>1: print(text.splitlines()[i-2])
print(f"{i}: {line}")
if i<text.splitlines().index(line): print(text.splitlines()[i])
except Exception as e:
print(f"Failed {url}: {e}")
PYRepository: manaflow-ai/cmux
Length of output: 34170
🌐 Web query:
github raw.githubusercontent.com Yeachan-Heo gajae-code packages/coding-agent/src/cli.ts --default
💡 Result:
The file packages/coding-agent/src/cli.ts within the Yeachan-Heo/gajae-code repository serves as the primary executable bootstrap for Gajae-Code (gjc) [1]. It is responsible for registering the CLI commands—including setup, deep-interview, ralplan, ultragoal, team, and rlm—and dispatching the agent into various operating modes such as interactive (TUI), print, RPC, bridge, and research [1][2][3]. Gajae-Code is an experimental, beta-stage coding-agent harness designed to run alongside existing developer tools like Claude Code or OpenCode [4][2]. It focuses on structured planning, persistent evidence, and isolated execution through a deliberately small workflow surface [2][5]. When executed, the CLI adapts user options into session configurations, which are then passed to the SDK layer (specifically packages/coding-agent/src/main.ts and the session manager) to construct and run the agent loop [1][3]. The project maintains its state, goals, and local overrides within a.gjc/ directory in the target repository [6][3].
Citations:
- 1: https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/master/docs/codebase-overview.md
- 2: https://gajae-code.com/
- 3: https://gajae-code.com/docs/architecture.html
- 4: https://github.com/Yeachan-Heo/gajae-code
- 5: https://gajae-code.com/docs/index.html
- 6: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
🌐 Web query:
github raw.githubusercontent.com Yeachan-Heo gajae-code packages/coding-agent src cli.ts --mpreset --default
💡 Result:
The file packages/coding-agent/src/cli.ts in the Yeachan-Heo/gajae-code repository serves as the primary executable bootstrap for the Gajae-Code (gjc) coding-agent harness [1][2]. It handles the registration of CLI commands (such as setup, deep-interview, ralplan, ultragoal, and team) and initiates the session by routing requests through to packages/coding-agent/src/main.ts [1][2]. The command usage mentioned in your query—specifically --mpreset and --default—relates to the configuration of the agent session. These flags are used within the CLI to initialize or configure the runtime environment with specific defaults [1][2]. Gajae-Code is designed as an external coding-agent harness that operates within a repository or worktree to provide structured planning, persistent evidence, and tmux-backed worker execution [3][4]. It is not a plugin for other agents like Claude Code or Codex CLI, but rather an independent tool that can be used alongside them [4]. For technical details regarding the CLI bootstrap, session lifecycle, and command handling, you can consult the codebase overview in the repository [1][2]. Integration patterns for external controllers are further documented in docs/bot-integration.md and docs/external-control-readiness.md [5][6].
Citations:
- 1: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/codebase-overview.md
- 2: https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/master/docs/codebase-overview.md
- 3: https://gajae-code.com/
- 4: https://github.com/Yeachan-Heo/gajae-code/blob/main/README.md
- 5: https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/master/docs/bot-integration.md
- 6: https://raw.githubusercontent.com/Yeachan-Heo/gajae-code/master/docs/external-control-readiness.md
🌐 Web query:
"github --default" "gajae-code" "mpreset"
💡 Result:
In the context of the Gajae Code (gjc) project, --mpreset is a command-line interface (CLI) flag used to specify a model profile [1][2][3]. Gajae Code is an experimental coding-agent harness [4][5][6]. When running gjc, the --mpreset flag allows users to define or select a pre-configured profile that determines which AI model and associated settings the agent uses for a given session [2][3][7]. Examples of usage found in project documentation and issues include: gjc --mpreset codex-medium gjc --mpreset codex-pro gjc --mpreset procedural These profiles are often used to manage model capabilities, thinking behaviors, and provider credentials [3]. The project maintains these model profiles to help users quickly switch between different operational modes [2][7]. You can find more information about configuring and using model profiles in the official Gajae Code documentation at gajae-code.com [5][6]. Note: The flag is specific to the gajae-code repository by Yeachan-Heo [4]. It should not be confused with the miniprogram-properties-reset library found on GitHub, which uses a different naming convention and purpose [8].
Citations:
- 1: https://github.com/Yeachan-Heo/gajae-code/blob/main/docs/models.md
- 2: feat(coordinator-mcp): support authoritative model profile selection via mpreset Yeachan-Heo/gajae-code#2003
- 3: https://gajae-code.com/docs/whats-new.html
- 4: https://github.com/Yeachan-Heo/gajae-code
- 5: https://gajae-code.com/docs/index.html
- 6: https://gajae-code.com/
- 7: Built-in minimax profiles reference non-existent model 'minimax-v3' — all minimax profiles 400 on launch Yeachan-Heo/gajae-code#656
- 8: https://github.com/joenix/miniprogram-properties-reset
🌐 Web query:
site:gajae-code.com/docs/models.md "default" "--default" "mpreset"
💡 Result:
I couldn’t find a docs/models.md page on gajae-code.com, but the closest relevant doc says:
--mpresetselects a session preset.--defaultpersists that preset as the startup default inconfig.yml.- Example:
gjc --mpreset daily - Example:
gjc --mpreset ultimate --default(ithub.global.ssl.fastly.net)
So the answer is: --mpreset is the runtime preset selector, and --default makes it the saved startup default. (ithub.global.ssl.fastly.net)
Citations:
- 1: https://ithub.global.ssl.fastly.net/Yeachan-Heo/gajae-code/blob/main/docs/multi-vendor-profiles.md
- 2: https://ithub.global.ssl.fastly.net/Yeachan-Heo/gajae-code/blob/main/docs/multi-vendor-profiles.md
🌐 Web query:
site:gajae-code.com/docs/gajae-code-mode.html "default" "--default" "mpreset"
💡 Result:
I couldn’t find an exact page match for site:gajae-code.com/docs/gajae-code-mode.html "default" "--default" "mpreset". The closest relevant docs are the v0.11.0 changelog and homepage, which mention --mpreset and default-model selection behavior. (gajae-code.com)
Citations:
Drop --default from restored Gajae Code argv.
--default persists --mpreset in the persistent Gajae configuration, not in one-off session behavior. Keeping it in booleanOptions rewrites the user’s configured startup default when a stale gjc --mpreset X --default launch is restored; move it to droppedOptions and cover it with a regression assertion.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift`
around lines 294 - 310, The booleanOptions list in
AgentLaunchSanitizerPrimaryPolicies must no longer treat --default as a restored
Gajae Code argument. Remove --default from booleanOptions, add it to
droppedOptions, and add a regression assertion confirming restored argv omits
--default while preserving the remaining options.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift (1)
353-364: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winRemove
-vfrom the GjC reject list unless it is specifically non-restorable.
-vis not the GjC version flag (--version), and GjC supports verbose/session verbosity via separate settings (--verboseand/verbose). Rejecting-vhere can prevent restoring saved interactive GjC launches that happen to include that flag.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift` around lines 353 - 364, Remove the "-v" entry from the GjC rejectOptions list, while retaining "--version" and the other explicitly rejected options. Do not add replacement flags; allow saved interactive GjC launches containing "-v" to be restored.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Localizable.xcstrings`:
- Around line 256691-256810: Limit all newly added localization entries in the
affected string blocks to the supported en and ja locales. Remove the added
legacy-locale blocks, including ar, bs, da, de, es, fr, it, km, ko, nb, pl,
pt-BR, ru, th, tr, uk, zh-Hans, and zh-Hant, while preserving the English and
Japanese entries across all referenced blocks.
---
Outside diff comments:
In
`@Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swift`:
- Around line 353-364: Remove the "-v" entry from the GjC rejectOptions list,
while retaining "--version" and the other explicitly rejected options. Do not
add replacement flags; allow saved interactive GjC launches containing "-v" to
be restored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: db2d014c-7463-4c20-83b9-79aa6c3b2680
📒 Files selected for processing (6)
CLI/CMUXCLI+GajaeCodeExtension.swiftCLI/cmux.swiftPackages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/AgentLaunchSanitizerPrimaryPolicies.swiftPackages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/AgentLaunchSanitizerTests.swiftResources/Localizable.xcstringstests/test_gajae_code_extension_install.py
| "ar": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "bs": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "da": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "de": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "en": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "es": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "fr": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "it": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "ja": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "km": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "ko": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "nb": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "pl": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "pt-BR": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "ru": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "th": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "tr": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "uk": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "zh-Hans": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| }, | ||
| "zh-Hant": { | ||
| "stringUnit": { | ||
| "state": "translated", | ||
| "value": "Gajae Code" | ||
| } | ||
| } |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Limit new localization entries to supported locales.
These new keys add translations for legacy locales even though this project currently requires only English (en) and Japanese (ja) for new localization work. Keep the en/ja entries and remove the newly added legacy-locale blocks unless those locales are intentionally reintroduced project-wide.
Based on learnings, new localization changes should target only English and Japanese; do not expand legacy locales with unaudited translations.
Also applies to: 256816-256934, 256941-257059, 257066-257185, 257191-257310, 257316-257435, 257441-257560, 257566-257685, 257691-257810, 257816-257934
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Localizable.xcstrings` around lines 256691 - 256810, Limit all
newly added localization entries in the affected string blocks to the supported
en and ja locales. Remove the added legacy-locale blocks, including ar, bs, da,
de, es, fr, it, km, ko, nb, pl, pt-BR, ru, th, tr, uk, zh-Hans, and zh-Hant,
while preserving the English and Japanese entries across all referenced blocks.
Source: Learnings
This branch has not been deployed
2 participants
Summary
gajae-code/gjchook installation using Gajae Code's native TypeScript extension APICompatibility and scope
Validated against the locally installed GJC 0.10.0 and upstream Gajae Code 0.11.11 (
0a18757555932a646b30ea99337fe42ffb016686). The extension uses the shared event surface present in both versions:session_start,session_switch,session_branch,before_agent_start, andagent_end.GJC sub-sessions and team workers are intentionally ignored so they cannot overwrite the leader surface binding. This PR provides lifecycle/restore integration only; it does not add Feed approval cards or workspace auto-naming because GJC does not expose the required stable approval/conversation-source contracts yet.
Testing
swift testinPackages/macOS/CMUXAgentLaunch: 253 tests passedpython3 tests/test_gajae_code_extension_install.py: passed against the tagged app's bundled CLIxcodebuild ... -scheme cmux-unit ... -only-testing:cmuxTests/TaskManagerResourcesTests: 22 tests passed./scripts/lint-pbxproj-test-wiring.sh: 602 test files checkedgit diff --check, and localization audit passedCMUX_SKIP_ZIG_BUILD=1 ./scripts/reload.sh --tag gajae-code-integration: succeeded on pushed HEADb4efe428cNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds first-class Gajae Code (
gjc) integration with an installable TypeScript extension that persists/restores sessions and preserves tmux identity. Task Manager now detectsgjc, and resume args/env are sanitized with safer defaults; CI covers the end-to-end flow.New Features
cmux hooks gajae-code(alias:gjc) installs/uninstalls a native@gajae-code/coding-agentextension at~/.gjc/agent/extensions/cmux-gajae-code-session.ts(respectsGJC_CODING_AGENT_DIRorGJC_CONFIG_DIR).session_start,session_switch,session_branch,before_agent_start,agent_end; on switch/branch we rebind the same surface and retire the prior record with address checks to avoid clobbering.gjc --resume <id>with tmux-aware restore (--tmux,GJC_TMUX_SESSION); sanitizer preserves tmux flags and essentialGJC_*config, and drops secrets, noninteractive flags, and team/worker identity.gjcprocesses and@gajae-code/coding-agentpaths (incl.gjc.js/bun/node entry points); resume argv usesgjc --resume <id>.tests/test_gajae_code_extension_install.py. Validated against GJC 0.10.0 and Gajae Code 0.11.x.Migration
cmux hooks gajae-code install(orcmux hooks setup). Uninstall:cmux hooks gajae-code uninstall.GJC_CODING_AGENT_DIR(full agent dir) orGJC_CONFIG_DIR(config root). Disable viaCMUX_GAJAE_CODE_HOOKS_DISABLED=1.Written for commit 3ed7ef6. Summary will update on new commits.
Summary by CodeRabbit
gjc) integration with session hooks, restoration, environment handling, and process detection.