Skip to content

Fix mobile feature flag isolation warning #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 1 commit into from
Closed

Fix mobile feature flag isolation warning #9013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/FeatureFlags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Observation
import PostHog
import os

struct CmuxFeatureFlagDefinition: Identifiable, Equatable {
nonisolated struct CmuxFeatureFlagDefinition: Identifiable, Equatable, Sendable {
var id: String { key }

let key: String
Expand Down Expand Up @@ -51,9 +51,9 @@ final class CmuxFeatureFlags {
#endif
private static let agentChatUIDefault = false
#if DEBUG
private static let mobileWorkspaceChangesDefault = true
private nonisolated static let mobileWorkspaceChangesDefault = true
#else
private static let mobileWorkspaceChangesDefault = false
private nonisolated static let mobileWorkspaceChangesDefault = false
#endif
private static let sidebarWorkspaceAgentSpinnerDefault = false
private static let simulatorDefault = true
Expand Down Expand Up @@ -95,7 +95,7 @@ final class CmuxFeatureFlags {
// Mac-side flag turns the whole feature off end to end. Release builds
// keep it off until the PostHog flag enables it; DEBUG keeps it on for
// dogfood.
static let mobileWorkspaceChangesFlag = CmuxFeatureFlagDefinition(
nonisolated static let mobileWorkspaceChangesFlag = CmuxFeatureFlagDefinition(
key: "mobile-workspace-changes-enabled-release",
title: String(
localized: "featureFlags.mobileWorkspaceChanges.title",
Expand Down