Generate and verify seven cmux-tui SDKs

[lawrencecchen]

Summary

• Generate exact protocol-10 types, codecs, commands, events, compatibility metadata, and manifests for Python, TypeScript, Rust, Go, Java, C++, and Zig.
• Keep transport, concurrency, lifecycle, stream, error, and convenience APIs handwritten and idiomatic per language.
• Add deterministic atomic generation with manifest-owned stale cleanup and two-pass output comparison.
• Add seven independent consumers: agent dashboard, watchdog, CI orchestrator, terminal bot, terminal frontend, browser controller, and provider controller.
• Preserve omitted, explicit-null, and concrete-value semantics across every generated model.
• Add package, consumer, publishing, and shared conformance CI for SDK version 0.4.0.

This is stacked on PR 8856 by Lawrence Chen, which remains open and unmerged.

Verification

• 27 inventory tests and exact 83-command, 44-event parity
• 9 schema tests and exact 74-type schema parity
• 44 generator tests plus clean deterministic generation for all seven SDKs
• Seven package matrices, including race, lint, documentation, installed-package, and external-consumer checks
• Seven independent application simulations using only public SDK APIs
• 11 conformance-harness tests
• 266/266 shared checks: 34 fake cases, metadata coverage, and 3 live TUI cases per language
• Exact headless cmux-tui build with Rust 1.95
• actionlint and diff checks

Dependencies

Python, TypeScript, Go, Java, C++, and Zig use only standard-library or platform runtime facilities. Rust uses serde, serde_json, and libc. Generation is a repository build tool and is not a consumer dependency.

Protocol follow-ups

Agent state events, typed terminal completion, mutation idempotency and revision guards, resumable stream checkpoints, stable machine-readable error codes, and browser frame encoding require protocol additions rather than SDK-only helpers.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Generates exact protocol-10 wire layers and manifests for seven cmux-tui SDKs and verifies them with a deterministic cross-language suite; CI builds, tests, and publishes 0.4.0. Replaces sleep-based timing with readiness hooks and selector-driven I/O so timeouts, partial-frame assembly, and close-unblock behavior are consistent; Java now uses separate read/write selectors, one per-command deadline across send/receive and stream reads, interrupt-aware writes, and closes on write failure.

• New Features

  • Deterministic SDK generator with IR validation and drift checks; cross-language conformance runner and clean, portable SDK consumers with cmux-client bumped to 0.4.0.
  • Unified CI workflows build all SDKs, run per-language conformance, and publish with a shared version checker.

• Bug Fixes

  • Deterministic wait hooks across SDKs: Java JsonLineConnection.receive(…, Runnable), CmuxStream.next(timeout, Runnable) with a preserved Deadline across messages, and CmuxClient.rawRequest(…, Runnable); Python transport _recv(before_wait=…) and stream _next(before_wait=…); C++ UnixTransport::set_before_receive_wait_for_testing with a waiting-receivers counter and idempotent signal.
  • Java transport uses read/write selectors with selector-driven writes, wakeups on close, explicit interrupted-write handling, closes on write failure, and binds commands and stream reads to one computed deadline across send/receive.
  • Tests replace sleeps with latches/promises and mocked timers; add deterministic partial/oversized frame checks; fix Java lifecycle tests.

^{Written for commit 1a0aeac. Summary will update on new commits.}

---

Note

Medium Risk
Changes core socket read/write and deadline behavior in Java and shared transport layers across bindings; scope is bounded by expanded lifecycle tests but incorrect deadline or selector handling could affect timeouts and close semantics in production clients.

Overview
Replaces sleep-based timing in C++, Java, Python, and TypeScript SDK tests with readiness hooks so lifecycle tests can assert close-unblock, partial frames, and timeouts without flakes.

Java JsonLineConnection now uses separate read and write selectors, a shared Deadline across send and receive for one command, selector-driven writes (no Thread.sleep spin), wakeups on close, and closes the connection on write failure. CmuxClient.rawRequest and CmuxStream.next gain package-private beforeWait runnables invoked immediately before blocking on the socket.

C++ UnixTransport adds a CMUX_CPP_TESTING hook before poll on receive; fake transports count waiting receivers. Python mirrors this with _recv / _next(before_wait=…) on the transport and stream paths.

TypeScript client tests use mock timers and deferred promises instead of racing real timeouts on stream idle behavior.

^{Reviewed by Cursor Bugbot for commit 1a0aeac. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes

  • Improved connection read and write coordination across C++, Java, and Python bindings.
  • Improved timeout and deadline handling for complete requests and responses.
  • Improved handling of partial messages, stream closure, interrupted waits, and connection shutdown.
  • Preserved unbounded stream behavior by default while maintaining explicit idle timeouts.

• Tests

  • Replaced timing-dependent lifecycle checks with deterministic synchronization.
  • Expanded coverage for blocked reads, cancellation, partial frames, oversized requests, and close behavior.

[greptile-apps]

Too many files changed for review (591 files, 100 file limit).

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The change adds pre-receive-wait hooks, separates Java read and write selectors, replaces timing-based waits with deadline-aware selection, and updates lifecycle tests across C++, Java, Python, and TypeScript to use deterministic synchronization.

Changes

Receive synchronization

Layer / File(s)	Summary
C++ receive hooks and synchronization cmux-tui/bindings/cpp/include/cmux/transport.hpp, cmux-tui/bindings/cpp/src/unix_transport.cpp, cmux-tui/bindings/cpp/tests/*	UnixTransport exposes a testing-only pre-wait hook. C++ tests synchronize on blocked receives, partial writes, and transport closure.
Java selector and pre-wait flow cmux-tui/bindings/java/src/com/cmux/raw/*	JsonLineConnection uses separate read and write selectors, shared deadlines, pre-wait callbacks, and selector-based write waits. Client and stream operations pass callbacks into receive operations.
Java lifecycle synchronization cmux-tui/bindings/java/tests/com/cmux/raw/LifecycleTest.java	Lifecycle tests use latches and request-receipt signals instead of fixed delays.
Python receive callbacks and lifecycle tests cmux-tui/bindings/python/cmux/raw/*, cmux-tui/bindings/python/tests/test_lifecycle.py	Streams pass optional pre-wait callbacks to JsonLineConnection.recv. The reader lifecycle test synchronizes on reader startup.
TypeScript deterministic client tests cmux-tui/bindings/typescript/test/client.test.ts	Client tests use deferred promises, settlement tracking, mocked timers, and request signals instead of event-loop delays.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CmuxStream
  participant JsonLineConnection
  participant readSelector
  participant Socket
  CmuxStream->>JsonLineConnection: receive(deadline, beforeWait)
  JsonLineConnection->>JsonLineConnection: invoke beforeWait
  JsonLineConnection->>readSelector: select(deadline)
  readSelector->>Socket: wait for readable data
  Socket-->>readSelector: readable data
  readSelector-->>JsonLineConnection: readiness
  JsonLineConnection-->>CmuxStream: decoded event

Loading

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation	✅ Passed	The PR diff contains only C++, Java, Python, and TypeScript binding changes; no production Swift files are changed, so the Swift actor-isolation check is not applicable.
Cmux Swift Blocking Runtime	✅ Passed	The PR diff contains no changed Swift files; all changes are in cmux-tui C++, Java, Python, and TypeScript files, so it adds no Swift blocking or timing primitive.
Cmux Browser Automation Off-Main	✅ Passed	The PR diff changes only cmux-tui binding files; TerminalController, worker policy, and policy tests are unchanged. No browser socket automation routing change is present.
Cmux Expensive Synchronous Load	✅ Passed	The PR diff from origin/main contains no Swift files or Swift hunks; it changes only C++, Java, Python, TypeScript, and C++ header binding files.
Cmux Cache Substitution Correctness	✅ Passed	The PR diff contains no production Swift, TypeScript, or JavaScript files; its only TypeScript change is the test file cmux-tui/bindings/typescript/test/client.test.ts.
Cmux No Hacky Sleeps	✅ Passed	The only changed TS/JS/shell/build path is a TypeScript test; its mock timers and deferred promises are deterministic test scaffolding allowed by the rule.
Cmux Algorithmic Complexity	✅ Passed	The full PR diff has no production Swift/TypeScript/JavaScript/shell changes; runtime edits add socket wait hooks and deadlines, not nested or repeated scalable-collection scans.
Cmux Swift Concurrency	✅ Passed	The complete PR diff changes only C++, Java, Python, and TypeScript files; it introduces no cmux-owned Swift code or Swift concurrency patterns.
Cmux Swift @Concurrent	✅ Passed	The PR diff contains 12 changed files, all in C++, Java, Python, or TypeScript; it contains no Swift changes, so this Swift-specific check is not applicable.
Cmux Swift Package Boundaries	✅ Passed	The PR-range diff contains no Swift paths or app-target Swift logic; its only related change is a vendored Ghostty submodule pointer, which the rule allows.
Cmux Swiftpm Lockfiles	✅ Passed	The merge-base diff changes only C++, Java, Python, and TypeScript transport/tests; no Package.swift, Package.resolved, .gitignore, Xcode project, workflow, or dependency paths changed.
Cmux Swift Logging	✅ Passed	The full origin/main...HEAD diff changes 12 C++, Java, Python, and TypeScript files, with no Swift files or Swift logging lines added or materially changed.
Cmux User-Facing Error Privacy	✅ Passed	The production diff adds only generic transport/deadline messages and test hooks; it adds no vendor names, secrets, headers, payload dumps, or raw upstream text, and existing command-error propagat...
Cmux Full Internationalization	✅ Passed	The PR changes only C++, Java, Python, and TypeScript transport/test code; it adds no Swift UI/catalog or web UI, metadata, markdown, changelog, or locale-message changes.
Cmux Swiftui State Layout	✅ Passed	The PR diff against its target-branch base contains only C++, Java, Python, and TypeScript files; it has no Swift or SwiftUI changes, so this check is not applicable.
Cmux Architecture Rethink	✅ Passed	The full PR diff changes only C++, Java, Python, and TypeScript files; it contains no Swift files or Swift architectural changes covered by this rule.
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	The PR diff from base contains 12 files, all under cmux-tui; no Swift, NSWindow, NSPanel, WindowGroup, or shortcut changes are present.
Cmux Source Artifacts	✅ Passed	The PR changes 12 intentional C++, Java, Python, and TypeScript source/test files under cmux-tui/bindings; no artifact directories, logs, media, caches, build output, or copied artifacts enter the...
Cmux No Test Or Debug Seam In Production Source	✅ Passed	The aggregate PR diff contains no Swift files under any production Sources path, so this Swift-specific check is not applicable.
Cmux No Ambient Global State	✅ Passed	The PR diff contains no Swift files or Swift declarations; all listed changes are C++, Java, Python, or TypeScript, so the Swift-only rule does not apply.
Title check	✅ Passed	The title clearly summarizes the primary objective: generating and verifying seven cmux-tui SDKs.
Description check	✅ Passed	The description provides a detailed summary and extensive verification results, but omits the template checklist, review trigger, and demo video sections.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat-tui-sdk-stack

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

This PR has 56,219 reviewable changed lines after ignored/generated files are excluded, above cubic's default 50,000-changed-line automatic review limit. The raw diff is 118,899 lines before ignored/generated files are excluded.

Most of the diff comes from:

• cmux-tui/bindings/go/generated_commands.go (~9,338 changed lines)
• cmux-tui/bindings/go/generated_types.go (~3,361 changed lines)
• cmux-tui/bindings/python/cmux/_generated/models.py (~2,069 changed lines)
• cmux-tui/bindings/codegen/emit_go.py (~1,881 changed lines)
• cmux-tui/bindings/go/generated_events.go (~1,721 changed lines)

Comment @cubic-dev-ai review this to review it anyway. If the largest files are generated or fixture data, add them to your ignored files in review settings or ignorePatterns in cubic.yaml - cubic will then review the rest automatically. You can also raise this limit in review settings.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8220a78. Configure here.}