Repository navigation
Fix integration review follow-ups - #8948
lawrencecchen merged 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe web test runner now requires Bun 1.3.14 or newer, with CI and self-hosted guard coverage. Notification history persistence no longer awaits the persistence call in ChangesBun version enforcement
Notification persistence scheduling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant run-tests.sh
participant Bun CLI
participant Bun test suite
run-tests.sh->>Bun CLI: Request bun --version
Bun CLI-->>run-tests.sh: Return installed version
run-tests.sh->>run-tests.sh: Compare version with 1.3.14
run-tests.sh->>Bun test suite: Run bun test --isolate when supported
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Greptile SummaryPins the required web test job to Bun 1.3.14 and enforces that minimum version in the shared test runner.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (4): Last reviewed commit: "test: rely on executed Bun version guard" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| break | ||
| } | ||
| await persistence.persist(snapshot) | ||
| persistence.persist(snapshot) |
There was a problem hiding this comment.
persist is an actor-isolated method called from the main-actor task, so removing await leaves an implicit cross-actor hop that emits a concurrency warning under the current Swift language mode and becomes a compile error under Swift 6. Keep the explicit await on this call.
File Used: .github/review-bot-rules/swift-actor-isolation.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f4eb5a5e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2f4eb5a to
7afcfd0
Compare
|
@greptileai review\n@codex review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_ci_self_hosted_guard.sh`:
- Around line 890-909: Extend the shared web test runner rejection checks to
also execute with CMUX_WEB_TEST_RUNNER_BUN_VERSION set to 1.3.13 and fail if it
is accepted. Keep the existing 1.2.14 rejection and 1.3.14 web-typecheck pin
assertion, ensuring the suite verifies the patch-level lower boundary.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b7b31094-ba83-47bb-a55f-9f829d7e2891
📒 Files selected for processing (4)
.github/workflows/ci.ymlSources/NotificationFeedHistoryStore.swifttests/test_ci_self_hosted_guard.shweb/scripts/run-tests.sh
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afcfd0bd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Exact head is now @codex review |
|
✅ Action performedReview finished.
|
|
Exact head is @codex review |
|
✅ Action performedReview finished.
|
20ee080
into
task-integrate-web-determinism-repairs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a26db9e77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if PATH="$fixture_dir/bin:/usr/bin:/bin" \ | ||
| CMUX_WEB_TEST_RUNNER_ARGS_LOG="$args_log" \ | ||
| CMUX_WEB_TEST_RUNNER_BUN_VERSION="1.3.13" \ | ||
| /bin/bash "$fixture_runner" >/dev/null 2>&1; then | ||
| echo "FAIL: shared web test runner must enforce the patch-level Bun isolation boundary" |
There was a problem hiding this comment.
The 1.3.13 regression case first appears in commit 0e9a1794, after commit 7afcfd0b has already implemented the minimum-version guard, so the series never demonstrates that this precise patch-level test fails without the fix; the earlier 1.2.14 case could still pass with an incorrect major/minor-only guard. Move this boundary assertion into the test-only commit before the implementation so CI records the required red-to-green transition.
AGENTS.md reference: AGENTS.md:L127-L134
Useful? React with 👍 / 👎.
1 participant
Repairs the exact-head Bun review finding on #8941.
--isolatestill leaks process-global mocks.The first commit is test-only and fails on the parent head. The second commit makes it pass.
Validation:
bash tests/test_ci_self_hosted_guard.shbun run typecheck