Skip to content

Fix main build: import CmuxWorkspaces in DockSplitStore+RestoredAgentLifecycle - #8873

Merged
azooz2003-bit merged 1 commit into
mainfrom
fix-dockstore-import
Jul 24, 2026
Merged

azooz2003-bit merged 1 commit into
mainfrom
fix-dockstore-import

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Jul 24, 2026 •

Copy link
Copy Markdown
Collaborator

Every macOS app build from main fails since #8690: the new extension file references PanelShellActivityState (defined in CmuxWorkspaces) but only imports Foundation. Sibling files using the same type already import CmuxWorkspaces. One-line import fix; verified by a successful tagged cloud build (ncon) from this branch. Blocks nightlies and all tagged reloads until merged.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes macOS app build by adding a missing CmuxWorkspaces import in DockSplitStore+RestoredAgentLifecycle.swift so PanelShellActivityState resolves. Unblocks nightlies and tagged releases.

Written for commit 3dc0237. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility when restoring agent lifecycles.

…Lifecycle

PanelShellActivityState lives in CmuxWorkspaces; the new extension file from
#8690 only imported Foundation, so
every macOS app build from main fails (cannot find type in scope). Sibling
files using the same type already import CmuxWorkspaces.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 38c79575-677f-4f18-b636-ede6e6d21515

📥 Commits

Reviewing files that changed from the base of the PR and between 301ddb6 and 3dc0237.

📒 Files selected for processing (1)
  • Sources/DockSplitStore+RestoredAgentLifecycle.swift

📝 Walkthrough

Walkthrough

The restored agent lifecycle file now imports the CmuxWorkspaces module. No exported or public declarations changed.

Changes

Restored agent lifecycle

Layer / File(s) Summary
Add workspace module import
Sources/DockSplitStore+RestoredAgentLifecycle.swift
Adds CmuxWorkspaces as a top-level dependency import.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Cmux Swift Blocking Runtime ❓ Inconclusive placeholder2 pending
✅ Passed checks (24 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main fix in the change.
Description check ✅ Passed The description covers the summary and testing and is mostly complete for the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation ✅ Passed PASS: The PR only adds a missing import in a @MainActor DockSplitStore extension; it introduces no new actor-isolation, Sendable, or background/UI access issues.
Cmux Browser Automation Off-Main ✅ Passed Touched file only adds CmuxWorkspaces import in DockSplitStore; no browser.* routing, WebKit waits, or worker-lane automation changes.
Cmux Expensive Synchronous Load ✅ Passed Diff only adds CmuxWorkspaces import; it doesn’t add or move any synchronous agent-history load, and the existing SharedLiveAgentIndex.shared call was already present.
Cmux Cache Substitution Correctness ✅ Passed Diff only adds an import line; no persistence/history/undo/snapshot read was swapped for a cache value.
Cmux No Hacky Sleeps ✅ Passed The commit only adds a CmuxWorkspaces import in a Swift file; it introduces no sleeps, timers, polling, or delay-based synchronization.
Cmux Algorithmic Complexity ✅ Passed Diff only adds an import in Sources/DockSplitStore+RestoredAgentLifecycle.swift; no collection scans or hot-path algorithm changes were introduced.
Cmux Swift Concurrency ✅ Passed The diff only adds an import in a synchronous extension; it introduces no DispatchQueue/Task/Combine/completion-handler concurrency pattern.
Cmux Swift @Concurrent ✅ Passed The PR only adds a CmuxWorkspaces import; the file contains no async/concurrent changes, so the Swift @concurrent rule is not implicated.
Cmux Swift Package Boundaries ✅ Passed Import-only fix in an app-target glue extension; no independently testable or reusable domain logic was added or expanded.
Cmux Swiftpm Lockfiles ✅ Passed PR only changes Sources/DockSplitStore+RestoredAgentLifecycle.swift; no .gitignore, Package.resolved, workflow, or package-reference/dependency files were touched.
Cmux Swift Logging ✅ Passed Diff only adds a CmuxWorkspaces import; no print/debugPrint/dump/NSLog, ad hoc logging, or sensitive log changes were introduced.
Cmux User-Facing Error Privacy ✅ Passed The diff only adds a duplicate CmuxWorkspaces import; it does not change any user-facing errors, alerts, or exposed sensitive details.
Cmux Full Internationalization ✅ Passed PR only adds a Swift import in a non-user-facing file; no localized strings, catalogs, or web i18n assets were changed.
Cmux Swiftui State Layout ✅ Passed Only a duplicate import in a non-SwiftUI store extension; no new ObservableObject/@published, GeometryReader, lazy-row store refs, or render-time state writes.
Cmux Architecture Rethink ✅ Passed Diff is a one-line import for PanelShellActivityState; no timing, state-owner, or lifecycle wiring changes, so it fits the rule’s small correctness-fix allowance.
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed Import-only change in a lifecycle store file; no NSWindow/NSPanel/WindowGroup code or cmux window-identifier routing was added or changed.
Cmux Source Artifacts ✅ Passed Only a hand-written Swift source file changed; no artifact, cache, build output, or scratch path was added.
Cmux No Test Or Debug Seam In Production Source ✅ Passed Only a duplicate CmuxWorkspaces import was added; no test/debug seam, guard, or accessor was introduced in production Sources code.
Cmux No Ambient Global State ✅ Passed Diff only adds a duplicate CmuxWorkspaces import; no new top-level func, mutable var, static namespace, or singleton was introduced.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-dockstore-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR attempts to fix a build breakage introduced by PR #8690 by adding import CmuxWorkspaces to DockSplitStore+RestoredAgentLifecycle.swift. However, PR #8869 (commit 34e7fa5df2) already landed the identical fix into main before this branch was rebased, so the import was already present on line 1 of the base.

  • The resulting file now has two consecutive import CmuxWorkspaces lines — a duplicate that compiles silently but is entirely redundant.
  • The build fix this PR targets is already complete; the only net change here is the spurious second import statement, which should be dropped before merging.

Confidence Score: 3/5

The single changed file ends up with two identical consecutive import statements; the duplicate compiles without error but is dead code, and the underlying fix was already merged separately.

PR #8869 already merged the same import CmuxWorkspaces addition into main before this branch was rebased. The only net change this PR introduces is a redundant second import on line 2, making the file slightly noisier but not broken. It should either be dropped entirely or trimmed to remove the duplicate before merging.

Sources/DockSplitStore+RestoredAgentLifecycle.swift — contains the duplicate import that needs to be removed.

Important Files Changed

Filename Overview
Sources/DockSplitStore+RestoredAgentLifecycle.swift Adds a duplicate import CmuxWorkspaces line; the identical import was already added by PR #8869 which merged into main before this branch was rebased, leaving two consecutive import statements.

Sequence Diagram

sequenceDiagram
    participant PR8690 as PR #8690 (merged)
    participant PR8869 as PR #8869 (merged)
    participant main as main branch
    participant PR8873 as PR #8873 (this PR)

    PR8690->>main: Introduces DockSplitStore+RestoredAgentLifecycle.swift with only import Foundation (build broken)
    PR8869->>main: Adds import CmuxWorkspaces (build fixed)
    Note over main: File now has CmuxWorkspaces + Foundation
    PR8873->>main: Rebased — adds duplicate import CmuxWorkspaces (fix already present, duplicate created)
Loading

Reviews (1): Last reviewed commit: "Fix main build: import CmuxWorkspaces in..." | Re-trigger Greptile

Comment on lines 1 to +2
import CmuxWorkspaces
import CmuxWorkspaces

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate import — fix already landed in #8869

PR #8869 (commit 34e7fa5df2) was merged into main before this branch was rebased, so import CmuxWorkspaces was already present at line 1 of the base. This PR adds an identical second import statement on line 2, producing two consecutive import CmuxWorkspaces lines. Swift accepts duplicate imports without a compile error, but the file now has dead/redundant lines and the stated fix is already in place. The second import CmuxWorkspaces should be removed.

@azooz2003-bit
azooz2003-bit merged commit 5188223 into main Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant