Repository navigation
Fix main build: import CmuxWorkspaces in DockSplitStore+RestoredAgentLifecycle - #8873
Conversation
…Lifecycle PanelShellActivityState lives in CmuxWorkspaces; the new extension file from #8690 only imported Foundation, so every macOS app build from main fails (cannot find type in scope). Sibling files using the same type already import CmuxWorkspaces. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe restored agent lifecycle file now imports the ChangesRestored agent lifecycle
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR attempts to fix a build breakage introduced by PR #8690 by adding
Confidence Score: 3/5The single changed file ends up with two identical consecutive import statements; the duplicate compiles without error but is dead code, and the underlying fix was already merged separately. PR #8869 already merged the same import CmuxWorkspaces addition into main before this branch was rebased. The only net change this PR introduces is a redundant second import on line 2, making the file slightly noisier but not broken. It should either be dropped entirely or trimmed to remove the duplicate before merging. Sources/DockSplitStore+RestoredAgentLifecycle.swift — contains the duplicate import that needs to be removed. Important Files Changed
Sequence DiagramsequenceDiagram
participant PR8690 as PR #8690 (merged)
participant PR8869 as PR #8869 (merged)
participant main as main branch
participant PR8873 as PR #8873 (this PR)
PR8690->>main: Introduces DockSplitStore+RestoredAgentLifecycle.swift with only import Foundation (build broken)
PR8869->>main: Adds import CmuxWorkspaces (build fixed)
Note over main: File now has CmuxWorkspaces + Foundation
PR8873->>main: Rebased — adds duplicate import CmuxWorkspaces (fix already present, duplicate created)
Reviews (1): Last reviewed commit: "Fix main build: import CmuxWorkspaces in..." | Re-trigger Greptile |
| import CmuxWorkspaces | ||
| import CmuxWorkspaces |
There was a problem hiding this comment.
Duplicate import — fix already landed in #8869
PR #8869 (commit 34e7fa5df2) was merged into main before this branch was rebased, so import CmuxWorkspaces was already present at line 1 of the base. This PR adds an identical second import statement on line 2, producing two consecutive import CmuxWorkspaces lines. Swift accepts duplicate imports without a compile error, but the file now has dead/redundant lines and the stated fix is already in place. The second import CmuxWorkspaces should be removed.
Every macOS app build from main fails since #8690: the new extension file references
PanelShellActivityState(defined in CmuxWorkspaces) but only imports Foundation. Sibling files using the same type already import CmuxWorkspaces. One-line import fix; verified by a successful tagged cloud build (ncon) from this branch. Blocks nightlies and all tagged reloads until merged.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes macOS app build by adding a missing
CmuxWorkspacesimport inDockSplitStore+RestoredAgentLifecycle.swiftsoPanelShellActivityStateresolves. Unblocks nightlies and tagged releases.Written for commit 3dc0237. Summary will update on new commits.
Summary by CodeRabbit