Repository navigation
Route Get Pro directly to Stripe checkout - #8813
Merged
Merged
Conversation
📝 WalkthroughWalkthroughPro pricing CTAs now always use the billing checkout endpoint. The checkout feature flag and fallback routing are removed, documentation is updated, and a component test verifies the checkout link output. ChangesPro checkout routing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (22 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR completes the Stripe checkout rollout by retiring the
Confidence Score: 5/5Safe to merge — the change is a straightforward flag retirement with no remaining branches dependent on the removed logic. Every changed file is consistent and purposeful: the flag evaluation is fully deleted, the retired-flags blocklist is updated, docs and the billing skill are kept in sync, and the new regression test pins the pre-hydration href to the checkout URL. TypeScript would catch any callers that still pass the removed fallbackHref prop, and CI lint would catch any attempt to reuse the retired flag key. No code paths were left partially wired. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User clicks Get Pro CTA] --> B[ProCtaLink onClick]
B --> C[posthog.capture checkout=true]
C --> D{useCheckoutRedirect.start}
D -- href starts with /api/billing/checkout --> E[preventDefault]
E --> F[fetch /api/billing/checkout?format=json]
F -- success --> G[window.location.assign Stripe URL]
F -- network failure --> H[window.location.assign fallback route]
H --> I[Server-side 302 to Stripe]
style A fill:#f0f0f0
style G fill:#d4edda
style I fill:#d4edda
Reviews (1): Last reviewed commit: "route Pro pricing CTA directly to checko..." | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/tests/pro-cta-link.test.tsx`:
- Around line 15-28: Add a client-side test for ProCtaLink that mocks the
redirect hook, simulates clicking the CTA, and asserts start is called with
checkoutHref and the click event, along with the unconditional checkout
analytics event. Keep the existing renderToStaticMarkup href assertions
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2f7e5cb0-a0d7-4fa2-a7d8-ba769e93fc3b
📒 Files selected for processing (7)
docs/pro-badge-options.htmlscripts/retired-feature-flags.txtskills/cmux-billing/SKILL.mdweb/app/[locale]/components/pro-cta-link.tsxweb/app/[locale]/pricing/page.tsxweb/app/lib/feature-flags.tsweb/tests/pro-cta-link.test.tsx
💤 Files with no reviewable changes (1)
- web/app/lib/feature-flags.ts
This was referenced Jul 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cd web && bun test tests/pro-cta-link.test.tsx tests/checkout-navigation.test.tsx tests/pricing-page.test.tsx tests/app-pricing-page.test.tsx tests/billing-checkout-route.test.tscd web && bun run typecheckpython3 scripts/lint-feature-flags.pyIssues
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Route all public Get Pro CTAs directly to Stripe Checkout and remove the rollout flag and download fallback for a consistent upgrade flow. Adds a server-rendered regression test to cover pre-hydration clicks.
/api/billing/checkout; remove the download confirmation fallback.pro-checkout-enabled-releaseflag and add it toscripts/retired-feature-flags.txt.ProCtaLinkto always start the checkout redirect and capturecheckout: true.Written for commit ef42016. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation