Repository navigation
Report and stop stale cmux-tui servers #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
623 commits
Select commit
Hold shift + click to select a range
abc6bf2
fix(tui): target terminal host cleanup exactly
lawrencecchen 5d251fd
test(tui): expose historical host cleanup scan
lawrencecchen 3211656
fix(tui): bound workspace host cleanup
lawrencecchen 0e9a283
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 452d795
test(tui): expose incomplete cleanup fences
lawrencecchen e92ee8b
fix(tui): fence server and workspace cleanup
lawrencecchen 6ef10db
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 77c7a86
test(tui): expose committed cleanup replay gaps
lawrencecchen 4c7bc6e
test(tui): require provider peer reaping
lawrencecchen be3545b
fix(tui): close cleanup lifecycle gaps
lawrencecchen 9f3f44d
test(tui): expose identify SDK schema drift
lawrencecchen 1164a68
fix(tui): declare identify cleanup status
lawrencecchen 022b4d5
test(tui): expose ownerless shutdown health gaps
lawrencecchen 2119c45
fix(tui): own complete shutdown health lifecycle
lawrencecchen 67a450e
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen d788676
test(tui): expose failed-spawn shutdown gap
lawrencecchen 54b7f62
fix(tui): fence unpublished child cleanup
lawrencecchen 2626760
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 6ae03fe
test(tui): expose merged shutdown regressions
lawrencecchen ca5a9e3
fix(tui): close merged release and shutdown gaps
lawrencecchen 4251bed
test: expose remaining lifecycle degradation
lawrencecchen 7ceb92a
fix: bound remaining lifecycle degradation
lawrencecchen 04bf011
test(tui): preserve unreadable host ownership
lawrencecchen db64c81
fix(tui): fail closed on canonical host records
lawrencecchen 19e63b7
test(tui): expose remaining ownership gaps
lawrencecchen a31f84d
fix(tui): fence host publication ownership
lawrencecchen 4704fbc
test(mac): expose lost surface creation retry
lawrencecchen 5137b03
fix: recover deferred surface creation
lawrencecchen 2bd396c
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen e0a903f
test(mac): expose stale recovery waiter race
lawrencecchen 268373d
fix(mac): transfer recovered surface ownership
lawrencecchen 6efb7bb
refactor(mac): align teardown ownership policy
lawrencecchen 57ee7c5
test: expose recovery boundedness failures
lawrencecchen 1abb1d6
fix: retain and pace recovery ownership
lawrencecchen 7f86fc0
test(tui): expose unbounded WebSocket teardown
lawrencecchen 6517f7f
fix(tui): bound WebSocket server teardown
lawrencecchen 14a1243
test(mac): expose nonblocking WebSocket clients
lawrencecchen 40e3742
test(tui): replace sleeps with lifecycle signals
lawrencecchen bfac26e
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 845a402
ci(tui): run Linux tests on Blacksmith
lawrencecchen f52c5b2
ci(tui): pin Blacksmith test runners
lawrencecchen d2c87a7
ci(tui): preserve macOS runner routing
lawrencecchen 702109a
ci(tui): allow Blacksmith macOS dispatch
lawrencecchen 4c46ceb
ci(tui): check the Valgrind execution job
lawrencecchen 980b8b1
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 0f2f651
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 95c09c7
Merge origin/main into feat-tui-server-upgrade
lawrencecchen dd79103
fix(tui): restore cross-platform compilation
lawrencecchen 899a7c4
fix(tui): repair exact-head review and CI findings
lawrencecchen 5600f28
fix(tui): clear remaining hosted lints
lawrencecchen 21a1689
fix(tui): reconcile hosted compile owners
lawrencecchen 35bb283
test(tui): expose unowned runtime launches
lawrencecchen 8829999
fix(tui): require tracked runtime launches
lawrencecchen dbb61f8
fix(tui): scope websocket test ownership
lawrencecchen 8a676ba
fix(ci): make review gates match lifecycle owners
lawrencecchen 1acf860
fix(ci): keep hosted platform owners portable
lawrencecchen 36edd98
test(macOS): bound stalled surface recovery waiters
lawrencecchen 59b6c93
fix(macOS): bound surface recovery admission
lawrencecchen f4a3f50
fix(ci): bound hosted lifecycle verification
lawrencecchen 1e409fb
fix(ci): reconcile hosted lifecycle owners
lawrencecchen 02bd74e
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen fafb0bc
fix(tui): reconcile hosted lock and formatting
lawrencecchen 71cdbef
fix(tui): align hosted platform ownership
lawrencecchen 976871a
fix(tui): satisfy hosted test lints
lawrencecchen 02e921c
test(tui): expose unconfirmed shutdown owners
lawrencecchen dc5789d
fix(tui): retain shutdown lifecycle owners
lawrencecchen cdb2aae
fix(tui): publish machine identity atomically
lawrencecchen 0959171
test(tui): cover process scan spawn barrier
lawrencecchen b6f0f72
fix(tui): guard process scan spawn
lawrencecchen 13d4509
fix(tui): retain daemon shutdown receipts
lawrencecchen 694a817
fix(tui): retain local shutdown ownership
lawrencecchen 13aafef
fix(tui): complete shutdown diagnostic fixture
lawrencecchen 6b80094
test(tui): capture complete shutdown failure
lawrencecchen 72f75ea
fix(tui): restore shared path import
lawrencecchen 40d0ffd
fix(tui): clear terminal owners on shutdown
lawrencecchen 7923bee
fix(macOS): require teardown ownership admission
lawrencecchen 4f92abd
fix(tui): close durable terminals atomically
lawrencecchen 9a1027d
Merge commit 'ada6abce88997cc6ce9af963e7fd5eddea4df2e6' into feat-tui…
lawrencecchen 843f561
test(macOS): preserve teardown ingress for owners
lawrencecchen 44ddaf6
fix(macOS): reserve teardown ingress with owners
lawrencecchen c604649
fix(tui): repair merged runtime structure
lawrencecchen 20f6c22
refactor(macOS): isolate teardown lifecycle types
lawrencecchen 5485a1b
test: retain accepted teardown coordinator
lawrencecchen c1d87f0
fix: retain accepted teardown submissions
lawrencecchen 16f96ad
fix(tui): restore merged browser failure owner
lawrencecchen 443f274
test(tui): implement ordered control sink
lawrencecchen a135cc2
test: preserve overflowed surface creation
lawrencecchen 512fea4
test(tui): pass hook payload to wheel fixtures
lawrencecchen 26ad7cb
fix: retry overflowed surface creation
lawrencecchen b53184d
fix(tui): reconcile merged shutdown contracts
lawrencecchen ad3f370
test(macOS): bound overflow recovery scans
lawrencecchen ef6fb6e
fix(macOS): bound overflow recovery work
lawrencecchen d908b30
fix(tui): satisfy hosted clippy cleanup checks
lawrencecchen 3d191bb
test(macOS): cover overflow recovery cancellation
lawrencecchen d8004c0
test(tui): bound browser transport shutdown
lawrencecchen 357114e
fix(tui): close browser transport during shutdown
lawrencecchen 9ae8289
test(tui): wait for fixture-owned readiness
lawrencecchen cbdbe69
fix(tui): complete shutdown owner adaptations
lawrencecchen ba68f2d
test(macOS): bound surface recovery overflow
lawrencecchen 5de6adc
fix(macOS): bound surface recovery overflow
lawrencecchen bc867fb
fix(tui): remove timeout qualification
lawrencecchen 72e54f7
test(tui): model adopted host identity
lawrencecchen 6a01424
test(tui): wait for renderer EOF on macOS
lawrencecchen bfbf7dc
test(macOS): cover stalled close admission
lawrencecchen c50e8f3
fix(macOS): fail stalled close admission
lawrencecchen 658ce4c
test(tui): exercise provider slot release
lawrencecchen 15b8524
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 8c02577
fix(tui): preserve terminal cleanup identity
lawrencecchen 0a72f83
test(tui): cover restored terminal tab ordering
lawrencecchen 50f1965
fix(tui): project restored terminal tabs
lawrencecchen 0f64dd0
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 4423a96
test(tui): exercise shutdown fanout ownership
lawrencecchen e322e8f
fix(macOS): lock recovery scheduler state
lawrencecchen 6304e4f
fix(macOS): type teardown gate continuation
lawrencecchen 001c62d
fix(macOS): isolate recovery scheduler lock state
lawrencecchen a78d60e
fix(macOS): type overflow registration result
lawrencecchen 0d4fbad
fix(tui): satisfy shutdown fanout lint
lawrencecchen 53f824c
test(macOS): bound stalled recovery failures
lawrencecchen b3131e0
fix(macOS): batch stalled recovery failures
lawrencecchen e5d35df
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 35ec016
fix(macOS): isolate failure drain lock state
lawrencecchen 9ae05b7
test(tui): signal CDP reader shutdown (#9926)
lawrencecchen ada14a9
test(tui): cover durable exit cleanup race
lawrencecchen 5b4bf85
fix(tui): acknowledge prepared host exits
lawrencecchen d52439c
test(tui): cover detached cleanup identity (#9945)
lawrencecchen 06ab13d
test(macOS): cover stalled close recovery order
lawrencecchen 51a3e44
fix(macOS): clear stalled admission before cleanup
lawrencecchen 913eca1
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into fe…
lawrencecchen dfdc00e
test(macOS): gate stalled recovery at cleanup
lawrencecchen 02df576
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 3e19143
test(tui): order final cleanup retry
lawrencecchen 44cb4a9
test(macOS): cover recovery failure handoff
lawrencecchen d5a974b
fix(macOS): order recovery failure handoff
lawrencecchen 5c7ee7b
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 159d36e
test(macOS): clear recovered creation failure
lawrencecchen 77f992d
fix(macOS): clear recovered creation failure
lawrencecchen d2799b7
test(tui): signal final cleanup retry
lawrencecchen a5569fa
test(tui): stage hook launcher fixtures (#9970)
lawrencecchen b227749
test(tui): keep failure probes owner-scoped
lawrencecchen df1f8de
Merge remote branch feat-tui-server-upgrade
lawrencecchen 9c125cd
test(tui): use imported frame errors
lawrencecchen 0625683
test(tui): retire cleanup owners directly
lawrencecchen d51dffe
test(macOS): retry stalled close recovery
lawrencecchen 1047d23
fix(macOS): retry stalled close recovery
lawrencecchen ebf50c1
fix(macOS): type stalled recovery grant
lawrencecchen d155d86
test(tui): match live agent projections
lawrencecchen 6445cad
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen b84df58
test: restore snapshot resume command assertion (#9976)
lawrencecchen 54c3c66
fix(macOS): isolate recovery failure UI
lawrencecchen f6c3d95
test(tui): signal transient host adoption
lawrencecchen 5b2b75d
test(tui): keep process retry coverage live (#9927)
lawrencecchen 2a4d112
test(tui): release adoption before listener wait
lawrencecchen b275a35
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 56fd019
test(macOS): return fake surface snapshot
lawrencecchen 5d0e40b
test(macOS): keep overflow recovery behind primary work
lawrencecchen 6245f55
fix(macOS): preserve recovery admission order
lawrencecchen 82e0977
fix(tui): retain catalog adoption owners
lawrencecchen b66922c
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen cf01408
test(macOS): retain pending recovery failure ownership
lawrencecchen f128fc0
fix(macOS): retain recovery failure delivery ownership
lawrencecchen f93d06f
test(tui): remove stale shell quote helper
lawrencecchen 988dc3d
test(macOS): declare recovery owner before cleanup
lawrencecchen 4cd584c
test(tui): wait for adoption reconnect receipt
lawrencecchen 23307cb
test(tui): signal adoption reconnect completion
lawrencecchen 505b4ed
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 1d3c6fd
fix(ci): require Blacksmith macOS verification
lawrencecchen cafaad9
refactor(tui): centralize browser runtime slot ownership (#9930)
lawrencecchen c89bf5c
test(macOS): cover nil AppKit subview insertion
lawrencecchen ad223db
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into fe…
lawrencecchen 304992a
fix(macOS): tolerate nil AppKit subview hooks
lawrencecchen 0ca0d11
test(tui): detach explicit attach fixture
lawrencecchen 45b5859
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 08a03da
test(tui): retain untracked shutdown fixture owner
lawrencecchen 59de735
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 724749b
fix(tui): retain failed attachment owners
lawrencecchen 7e4b9a9
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 44ae65d
test(tui): close quota owners explicitly
lawrencecchen 4671bb2
test(tui): retain failed quota cleanup owner
lawrencecchen d077933
test(tui): keep undone terminals catalog-owned
lawrencecchen 5dccd41
test(macOS): retain repeated stalled recovery
lawrencecchen ed1f16d
fix(macOS): retain repeated stalled recovery
lawrencecchen 407ae05
test(macOS): preserve stalled recovery order
lawrencecchen 6d4fade
fix(macOS): preserve recovery delivery order
lawrencecchen 2956e1e
test(tui): retry committed cleanup receipts
lawrencecchen 09cba8e
test(tui): await configured server exit event (#9995)
lawrencecchen 88abaef
test(tui): target terminal shutdown ownership
lawrencecchen 84b5d3d
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into fe…
lawrencecchen 2866d4a
fix(tui): retain terminal close ownership
lawrencecchen d95c93a
test(tui): cover all process barrier launches
lawrencecchen be63aae
fix(tui): guard every production child launch
lawrencecchen 90f0f4a
test(macOS): preserve overflow admission order
lawrencecchen d09ac55
fix(macOS): preserve overflow recovery order
lawrencecchen 41994b9
test(tui): require exact exit sidecar cleanup
lawrencecchen 3383ef5
fix(tui): acknowledge confirmed host exits
lawrencecchen 092b827
refactor(macOS): use restore pacing entrypoint
lawrencecchen dba1c99
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into cl…
lawrencecchen bfce2a8
test(cdp): stop after child wait ownership loss
lawrencecchen 7062138
fix(cdp): stop reaping after wait ownership loss
lawrencecchen c6d1ca7
test(tui): model exact pending host reconnect
lawrencecchen 29f2905
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen eaaea8a
test(tui): wait for websocket connection owners
lawrencecchen 9b92bbb
fix(tui): await websocket shutdown owners
lawrencecchen 5e10f0f
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into cl…
lawrencecchen 9bdfa2b
fix(tui): observe completed websocket shutdown
lawrencecchen e5b788b
test(tui): cover unavailable task-name identity
lawrencecchen e14aaff
test(tui): preserve exited terminal replay
lawrencecchen 83e4070
fix(tui): fall back to exact PID versions
lawrencecchen 8a5623e
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 93d92ea
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into cl…
lawrencecchen 54906b3
test(tui): use imported JSON null
lawrencecchen 803d135
fix(tui): retain resource replay revision
lawrencecchen 2fc7768
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into cl…
lawrencecchen 4bdf024
test(tui): preserve process identity across exec
lawrencecchen a531585
test(tui): cover persisted close and child identity
lawrencecchen f24608d
fix(tui): read child PID versions directly
lawrencecchen 44e505d
fix(tui): retain process ownership across exec
lawrencecchen 3a319f8
test(tui): preserve terminal tombstone on restart
lawrencecchen c065d41
fix(tui): close failed renderer writers
lawrencecchen 90d96c4
Merge origin/main into feat-tui-server-upgrade
lawrencecchen 05b67cc
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into cl…
lawrencecchen fc002c2
test(tui): cover restricted child signaling
lawrencecchen 0630967
fix(tui): bracket restricted process identity
lawrencecchen 2f56746
test(tui): use valid exact child signal
lawrencecchen c98d473
Merge branch 'proof-pr8769-signal-red' into closeout-pr8769-09cba8e
lawrencecchen 6b9e468
test(tui): use supported audit-token signals
lawrencecchen 4f9bb7e
fix(tui): own macOS processes by unique ID
lawrencecchen 505c836
test(tui): cover unique scope signaling
lawrencecchen 11b2648
test(tui): cover cross-platform scope signaling
lawrencecchen 95c9cf0
style(tui): apply hosted rustfmt
lawrencecchen 6414560
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen b0950b2
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into fe…
lawrencecchen f860e5f
fix(tui): reconcile hosted compile owners
lawrencecchen 9fdb2ed
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 7fe82ba
fix(ci): verify PyPI artifact version
lawrencecchen 84ebf7e
fix(tui): align merged shutdown checks
lawrencecchen 90357a0
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 4c9a853
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 3228548
test(macOS): release fake runtime pointers through override
lawrencecchen bcab6cc
fix(macOS): honor test surface free overrides
lawrencecchen 7a31854
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen 19507d4
fix(tui): restore canonical lifecycle CLI routing
lawrencecchen bd8ac6b
Merge remote-tracking branch 'origin/main' into feat-tui-server-upgrade
lawrencecchen a4ab577
test(macOS): reject stale teardown failures
lawrencecchen f3c2300
fix(macOS): cancel stale teardown failures
lawrencecchen 6c76dc1
fix(tui): connect legacy lifecycle ownership
lawrencecchen f3be93e
fix(tui): connect legacy lifecycle ownership
lawrencecchen 5c74e2b
Merge remote-tracking branch 'origin/feat-tui-server-upgrade' into fe…
lawrencecchen 851a0e4
fix(tui): compile lifecycle compatibility tests
lawrencecchen f0c86bb
test(macOS): bound repeated failure delivery
lawrencecchen b9ad9df
fix(macOS): compact stale failure deliveries
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...OS/CmuxTerminal/Sources/CmuxTerminal/Lifecycle/TerminalSurfaceRuntimeActiveTeardown.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import Foundation | ||
|
|
||
| internal struct TerminalSurfaceRuntimeActiveTeardown: Sendable { | ||
| let ticketID: UUID | ||
| let task: Task<Void, Never> | ||
| let watchdogTask: Task<Void, Never>? | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.