Repository navigation
Move active surface between existing panes - #8735
Closed
kyler-jh67 wants to merge 1 commit into
Closed
kyler-jh67 wants to merge 1 commit into
kyler-jh67 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Superseded by #8751, submitted from the preferred contributor account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabManagerinto the existingWorkspace.moveSurfaceownership-transfer path.All six new shortcut actions intentionally start unbound: the suggested Control-Command-arrow chords already belong to pane-focus actions. They remain discoverable and configurable in Settings and the command palette.
Scope
This is the focused existing-pane interaction slice (PR 1B) from the movement proposal. It does not create panes or consolidate cross-workspace/window transfer.
Verification
swift build --package-path Packages/macOS/CmuxSettingsscripts/lint-pbxproj-test-wiring.sh(568 test files)scripts/check-pbxproj.shResources/Localizable.xcstringsgit diff --checkswiftc -parseover every changed Swift source and the focused test file./scripts/test-unit.sh --filter MoveSurfaceBetweenPanesTests— blocked before test execution because this machine has Command Line Tools only;xcodebuildrequires a full Xcode installation.swift test --package-path Packages/macOS/CmuxSettings— blocked because the Command Line Tools toolchain does not provide theTestingmodule used by the package tests../scripts/reload.sh --tag move-pane— blocked because Zig is not installed; full Xcode is also unavailable for the subsequent app build.Test coverage added
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Add commands to move the active surface between existing panes (previous/next or left/right/up/down) without creating new panes. Actions work from shortcuts, the Command Palette, and the View menu, keeping focus and surface identity, inserting after the destination’s selected tab, wrapping prev/next, and collapsing empty source panes.
New Features
TabManagerinto the existingWorkspace.moveSurfacepath for consistent transfer and focus restore.Migration
Written for commit 640a88e. Summary will update on new commits.
Closes #8745