Repository navigation
Use native workspace-only bottom search on iOS #8645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
012885e
feat(ios): add workspace-only bottom search
8288249
fix(ios): use native toolbar workspace search
2c2287b
fix(ios): integrate workspace search with tab bar
7c71bab
test(ios): cover persistent contextual search
azooz2003-bit eaecf92
fix(ios): keep search stable across primary tabs
azooz2003-bit 1141f72
Merge remote-tracking branch 'origin/main' into task-ios-workspace-bo…
azooz2003-bit 2fa4df3
test(ios): focus notification search assertion
azooz2003-bit 4dc5f9e
fix(ios): make notification search resilient
azooz2003-bit 4022dcb
fix(ios): close contextual search review feedback
azooz2003-bit 9755d32
fix(ios): stabilize contextual search state
azooz2003-bit ade0028
merge origin/main into iOS search tab PR
azooz2003-bit 763e9cb
fix(ios): preserve search query across submit cleanup
azooz2003-bit eb0daa9
fix(ios): address search review lifecycle
azooz2003-bit 7e60ac7
fix(ios): isolate search state and projection work
azooz2003-bit 425aa01
fix(ios): split search content from root lifecycle
azooz2003-bit 64c1eb4
fix(ios): guard search activation ownership
azooz2003-bit 97736d2
fix(ios): deactivate search before result navigation
azooz2003-bit 64a4038
fix(ios): preserve search result navigation ownership
azooz2003-bit 65237a8
fix(ios): keep notification search open until commit
azooz2003-bit 7b7d607
fix(ios): isolate notification search navigation path
azooz2003-bit 4e8a3c0
fix(ios): show workspace action failures from search
azooz2003-bit 37824d9
fix(ios): bound notification feed search source
azooz2003-bit db74dcf
fix(ios): stabilize retained notification feed revisions
azooz2003-bit 2264ffc
fix(ios): bound notification feed aggregation work
azooz2003-bit 3afa599
fix(ios): keep notification feed persistence loadable
azooz2003-bit bdc7b37
fix(ios): bound notification feed wire recovery
azooz2003-bit 390c94c
fix(ios): preserve bounded notification feed revisions
azooz2003-bit 44efeb1
fix(ios): make notification feed recovery transactional
azooz2003-bit eafedd0
fix(ios): bound notification feed recovery scan
azooz2003-bit 1d9bb7c
fix(ios): isolate search drafts and recovery metadata
azooz2003-bit 03d0755
fix(ios): align notification feed quarantine naming
azooz2003-bit e370d33
fix(ios): bound notification feed history text
azooz2003-bit 85582f3
fix(ios): bound notification feed ingress recovery
azooz2003-bit 7d3e771
fix(ios): coalesce notification feed persistence
azooz2003-bit faed67e
fix(ios): parse notification feed history metadata safely
azooz2003-bit 67a54ca
fix(ios): recover oversized notification feed metadata from tail
azooz2003-bit 1b8879d
fix(ios): retain notification feed projections during rebuild
azooz2003-bit 3c83691
fix(ios): disable stale notification rows during source rebuild
azooz2003-bit 952050f
fix(ios): bound notification feed migration and decode
azooz2003-bit 648c094
fix(ios): fail closed on oversized feed edge cases
azooz2003-bit 7201cae
fix(ios): cancel notification feed decode workers
azooz2003-bit 5c946a9
fix(ios): cap notification search source state
azooz2003-bit 228883f
fix(ios): normalize primary search queries
azooz2003-bit 210cca0
fix(ios): preserve editable search drafts
azooz2003-bit d418d55
fix(ios): preserve filtered notification empty states
azooz2003-bit 916ea31
fix(mac): retire oversized history quarantines
azooz2003-bit b49f210
fix(ios): route notification links by search scope
azooz2003-bit a6310c3
fix(ios): preserve notification source tails
azooz2003-bit 2dfd323
fix(mac): fit notification feed frames in one pass
azooz2003-bit 484bdc7
fix(ios): aggregate scoped notification feeds
azooz2003-bit 8ec3425
fix(mac): recover oversized history scan exhaustion
azooz2003-bit dfd88bd
fix(ios): target notification feed bulk scope
azooz2003-bit e044eab
fix(ios): satisfy notification search policy gates
azooz2003-bit 73331dc
fix(ios): ignore initial native search cleanup
azooz2003-bit 0304d5f
fix(ios): use native task composer toolbar on iOS 26
azooz2003-bit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user clears a non-empty query and then dismisses search,
commitNativeSearchTextleaves the clear inpendingEmptyCommit. This deactivation path deletes that pending change and copies the old committed query back into the native field. Reopening search therefore restores the query the user explicitly cleared. The lifecycle state needs to preserve queries on presentation-only dismissal without treating a user clear as presentation cleanup.Rule Used: Flag Swift fixes that patch symptoms while leaving... (source)