fix(tui): make attached frontends match source state - #8476
Closed
lawrencecchen wants to merge 30 commits into
Closed
lawrencecchen wants to merge 30 commits into
lawrencecchen wants to merge 30 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lawrencecchen
force-pushed
the
codex/cmux-tui-frontend-parity
branch
from
July 20, 2026 00:41
541d4dd to
0b34c26
Compare
lawrencecchen
force-pushed
the
codex/cmux-tui-viewer-lease-release
branch
from
July 20, 2026 00:41
18f39a6 to
021a8e3
Compare
added 15 commits
July 19, 2026 19:03
lawrencecchen
force-pushed
the
codex/cmux-tui-frontend-parity
branch
from
July 20, 2026 02:58
0b34c26 to
b3e87d4
Compare
lawrencecchen
force-pushed
the
codex/cmux-tui-viewer-lease-release
branch
from
July 20, 2026 02:58
021a8e3 to
293b538
Compare
added 4 commits
July 21, 2026 15:34
…ux-tui-frontend-parity # Conflicts: # cmux-tui/crates/cmux-tui-core/src/mux.rs
…ux-tui-frontend-parity
…ux-tui-frontend-parity
…i-frontend-parity
added 11 commits
July 21, 2026 20:30
# Conflicts: # cmux-tui/spec/commands.md # ghostty
This was referenced Jul 23, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8475. Consumed by cmux Browser #14, which pins this exact commit (
768c8d3f99a3b04294a6305a555cc48af638e7a1) and Manaflow Ghosttyd6f611a3077aa12510761ca10e2a5e0a93979536.The complete stack contains canonical cmux main
b5631833741d0a1a2c25ede49988eadf2f412dd2.Summary
These focused attach, registry, state, resize, input, and handoff APIs are sufficient for cmux Browser. Another broad custom-frontends abstraction is not required.
State and failure semantics
Latest-main regression audit
The stacked tip was compared directly with canonical main rather than only tested in isolation. That exposed nine stack-only Clippy warnings, a stale rendered-bounds selection regression, and a smoke assertion that incorrectly assumed indexed foreground SGR would never share an escape with background state.
This tip clears every warning, restores live bounds, and makes the smoke parser recognize exact SGR commands without stripping valid combined foreground/background output. Indexed and RGB operands are consumed atomically, so an operand value such as
31cannot falsely satisfy a foreground-red assertion.Validation
cargo fmt --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo check --workspace --all-targets --lockedcargo test --workspace --lockedcargo build -p cmux-tui --lockedpython3 scripts/smoke-tui.py(SMOKE OK)python3 scripts/smoke-attach.py(ATTACH SMOKE OK)768c8d3...and Ghosttyd6f611a...; all 585 bundled Ghostty resource hashes verify