Repository navigation
Fix remote tmux seed/live output ordering - #8436
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The mirror delivered live output while capture-pane and pane-state replies independently repainted the same surface. Which write won depended on transport timing, and a live screen-title filter could be left mid-escape when synthetic snapshot bytes arrived. Tailscale SSH exposed both ordering assumptions through different latency and chunk boundaries.
Regression coverage
The test-only first commit feeds the real incremental control parser with deterministic uneven transport chunks and covers:
The fix commit adds typed-seed observer coverage, including the no-duplicate compatibility contract.
A manual CI run was started on the test-only commit to record red/green status, but the existing strict determinism guard failed first on three unrelated sleep-then-assert findings in MobileShellRenderGridLivenessTests.swift. That preflight skipped the app-host tests, so the PR keeps the requested two-commit test/fix structure without claiming that unrelated CI red as regression proof.
Validation
Closes #7990
Summary by CodeRabbit
New Features
Bug Fixes
Tests