Skip to content

Regenerate stale diff viewer bundle - #8416

Merged
lawrencecchen merged 1 commit into
mainfrom
task-refresh-diffsurface-generated-chunk
Jul 19, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
task-refresh-diffsurface-generated-chunk

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • regenerate the committed diff viewer chunk from the current webviews sources
  • restore react-apps-check on current main without changing source behavior

Testing

  • reproduced ./scripts/build-webviews-app.sh --check failing only for Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs
  • verified fresh regeneration matches Austin Wang's standalone commit 1ad4076806cb8e35a2c31ff5a52c24e87d15c235 byte for byte
  • ./scripts/build-webviews-app.sh --check
  • ./scripts/check-webviews-react-compiler.mjs
  • cd webviews && bun run typecheck
  • cd webviews && bun run test (230 passed)
  • cd webviews && bun run lint:ci
  • cd webviews && bun run react-doctor:ci
  • git diff --check

Issues


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Summary by cubic

Regenerated the stale diff viewer bundle Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs to sync with current webviews sources and unblock react-apps-check on main. No source or runtime changes.

  • Bug Fixes
    • Rebuilt the bundle with ./scripts/build-webviews-app.sh to match current webviews code and prevent drift.
    • Ensures webviews build and React compiler checks pass again.

Written for commit a389d76. Summary will update on new commits.

Review in cubic

react-apps-check fails because #7804 committed a bundled chunk one line
out of sync with its webviews sources (reproduces on plain main).
Regenerated with ./scripts/build-webviews-app.sh as the check instructs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9ec673e1-59ea-4c34-9071-f2ecc5d0074b

📥 Commits

Reviewing files that changed from the base of the PR and between 2c07967 and a389d76.

📒 Files selected for processing (1)
  • Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-refresh-diffsurface-generated-chunk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR regenerates the committed diff viewer chunk bundle (Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs) from the current webviews sources to fix a stale artifact that was causing ./scripts/build-webviews-app.sh --check to fail on main.

  • The single changed line in the minified bundle is a byte-for-byte match with the standalone source commit 1ad4076806cb8e35a2c31ff5a52c24e87d15c235, confirming no behavioral changes were introduced.
  • No source code was modified; only the committed generated chunk needed refreshing to restore the react-apps-check CI gate.

Confidence Score: 5/5

Safe to merge — only regenerates a stale committed build artifact with no source behavior changes.

The single changed line in this minified bundle is a verified byte-for-byte match with the upstream source commit. No source files were touched, the CI check script validates the bundle against sources, and the PR description documents successful runs of typecheck, tests, lint, and the react-doctor. Nothing functionally new is introduced.

No files require special attention.

Important Files Changed

Filename Overview
Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs Regenerated committed build artifact to match current webviews sources; one minified line updated, no behavioral changes, verified byte-for-byte against the canonical source commit.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[webviews source files] --> B[build-webviews-app.sh]
    B --> C[diffSurface.mjs bundle]
    C --> D{--check flag}
    D -->|stale bundle| E[CI fails]
    D -->|fresh bundle matches| F[CI passes]
    C --> G[Committed to Resources/markdown-viewer/webviews-app/chunks/]
    G -->|PR regenerates| H[Byte-for-byte match with source commit 1ad4076]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[webviews source files] --> B[build-webviews-app.sh]
    B --> C[diffSurface.mjs bundle]
    C --> D{--check flag}
    D -->|stale bundle| E[CI fails]
    D -->|fresh bundle matches| F[CI passes]
    C --> G[Committed to Resources/markdown-viewer/webviews-app/chunks/]
    G -->|PR regenerates| H[Byte-for-byte match with source commit 1ad4076]
Loading

Reviews (1): Last reviewed commit: "Regenerate stale webviews diffSurface ch..." | Re-trigger Greptile

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a389d76c47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lawrencecchen
lawrencecchen merged commit 3c19e26 into main Jul 19, 2026
21 of 24 checks passed
@lawrencecchen
lawrencecchen deleted the task-refresh-diffsurface-generated-chunk branch July 19, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants