Repository navigation
feat(tui): add shared workspace registry protocol - #8340
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe TUI adds stable workspace keys and monotonic revisions across mux state, commands, snapshots, events, and language bindings. Workspace mutations gain key selection and revision guards. Attachment sizing, failed-attach cleanup, terminal-event preservation, build metadata, and related tests are updated. ChangesWorkspace registry and protocol
Runtime event and attachment behavior
Estimated code review effort: 5 (Critical) | ~100 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant ControlServer
participant Mux
Client->>ControlServer: Send workspace command with key and expected_revision
ControlServer->>Mux: Resolve selector and apply guarded mutation
Mux-->>ControlServer: Return workspace metadata and revision
ControlServer-->>Client: Return JSON response and tree event
Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings)
✅ Passed checks (22 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ace-registry # Conflicts: # cmux-tui/bindings/python/tests/test_protocol.py # cmux-tui/bindings/rust/src/lib.rs # cmux-tui/bindings/typescript/test/protocol-types.ts # cmux-tui/crates/cmux-tui-core/src/mux.rs # cmux-tui/crates/cmux-tui-core/src/server.rs # cmux-tui/docs/protocol.md # cmux-tui/spec/commands.md
…ace-registry # Conflicts: # cmux-tui/bindings/go/client_test.go # cmux-tui/bindings/java/src/com/cmux/IdentifyResult.java # cmux-tui/bindings/java/tests/com/cmux/JsonTest.java # cmux-tui/bindings/python/cmux/client.py # cmux-tui/bindings/typescript/src/protocol/commands.ts # cmux-tui/crates/cmux-tui-core/src/server.rs # cmux-tui/crates/cmux-tui/src/main.rs # cmux-tui/spec/commands.md
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Greptile Go |
Adds the shared workspace registry and attach lifecycle needed by detached/custom cmux TUI frontends.
What it adds
Correctness work
Verification
cargo test -p cmux-tui-core: 221 unit, 7 browser-runtime, 26 PTY, and 9 WebSocket testscargo test -p cmux-tui: 268 unit and 5 CLI integration testsFinal reviewed head:
7b0288a3b55dd9596f0f4d42543deb4992b065cc