Skip to content

Fix explicit-self capture breaking clean macOS builds of main #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 3 commits into from
Jul 17, 2026
Merged

Fix explicit-self capture breaking clean macOS builds of main #8331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0160d99
Fix escaping-closure capture in sidebar slot view tint
Jul 17, 2026
9522349
Fix explicit-self capture in sidebar slot tint closure
Jul 17, 2026
d291005
Use captured sidebar icon tint color
lawrencecchen Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Sidebar/AppKitList/Cells/SidebarWorkspaceRowSlotViews.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ final class SidebarRowPullRequestIconView: NSView {
)
// Tint inside the image first: .sourceAtop against the view's
// transparent backing draws nothing (no destination pixels).
let tinted = NSImage(size: image.size, flipped: false) { drawRect in
let tinted = NSImage(size: image.size, flipped: false) { [color] drawRect in
image.draw(in: drawRect, from: .zero, operation: .sourceOver, fraction: 1)
color.set()
drawRect.fill(using: .sourceAtop)
Expand Down