-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Restore Codex sessions through user-owned roots #8321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
aaa7c4e
test: reject unindexed Codex review restore IDs
lawrencecchen 97203e4
fix: require Codex-owned restore sessions
lawrencecchen df802cb
Merge remote-tracking branch 'origin/main' into feat-durable-codex-se…
lawrencecchen 01fbee4
Merge remote-tracking branch 'origin/main' into feat-durable-codex-se…
lawrencecchen 6e949f8
test: reproduce indexed Codex subagent restore takeover
lawrencecchen bb1022b
fix: resolve Codex subagents to restore roots
lawrencecchen 2d7469e
chore: keep restore fix scoped
lawrencecchen 71372d0
fix: verify detached split restore inputs
lawrencecchen e740f7f
Merge remote-tracking branch 'origin/main' into feat-durable-codex-se…
lawrencecchen 50a4e21
test: reject indexed codex exec workers
lawrencecchen e0b687f
fix: keep codex exec workers off restore bindings
lawrencecchen bcec85d
test: expose stale codex thread cache
lawrencecchen 72885ea
fix: refresh codex restore ownership per lookup
lawrencecchen 2c0463c
test: preserve live codex restore bindings
lawrencecchen d3af20b
fix: keep live codex restore bindings
lawrencecchen 346b6e0
test: preserve codex executable after resume
lawrencecchen 5317803
fix: retain codex executable after resume
lawrencecchen 67caf90
test: preserve codex binding across empty scans
lawrencecchen e78b706
fix: keep agent restore identity across scans
lawrencecchen 62cff23
test: rebind resumed codex to current pid
lawrencecchen cfe8d7e
fix: rebind resumed agents to current pid
lawrencecchen 209e39c
test: close Codex restore evidence gaps
lawrencecchen e8ee02a
fix: verify legacy Codex restore bindings
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codexSessionResumeVerifieris a process-lifetime static with an internalCodexThreadIndexCachethat loadsstate_5.sqliteonce per database path and never re-reads it. Any Codex session created after the first hook fires won't appear in the frozen dictionary; those hooks fall through to thetranscriptPath/legacyRolloutpath. For modern Codex hooks that includetranscript_paththis is a silent degradation, but for hooks that don't include it (e.g. stripped environments) the valid new session is incorrectly rejected as a review UUID. A targeted re-query on cache miss — rather than treating an empty result as final — would keep the cache warm for subsequent look-ups while still loading new entries that Codex indexed after startup.