Repository navigation
Revert "Settings > Browser > Extensions: import, add-unpacked, and live enable/disable for web extensions" - #8306
Merged
Conversation
…ve enabl…" This reverts commit 8f6cd59.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
|
Too many files changed for review. ( Bypass the limit by tagging |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (118)
📝 WalkthroughWalkthroughThe PR removes Safari Web Extension models, hosting, settings, UI, navigation, ownership, and test infrastructure. Browser construction and navigation dependencies are simplified, terminal input can wait for surface readiness, JSON settings mutation APIs are streamlined, and auxiliary-window close-shortcut ownership moves into app-level wiring. ChangesBrowser Web Extension removal
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7699
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Reverts the Browser Extensions feature and all WebKit web‑extension hosting. Removes the
browser.webExtensionssetting, related UI, discovery/hosting code, and dependent APIs to restore the previous browser behavior.Refactors
browser.webExtensions,BrowserWebExtensionsCard, discovery/import flows, and all related localizations.BrowserWebExtensionSupportand all popout/permission/toolbar/tab adapter types.BrowserPanel; removed extension navigation/context switching.AppDelegate,DockSplitStore,TabManager, andWorkspacefor extension ownership, routing, and focus.JSONConfigStore: removedupdate(_:); simplifiedJSONConfigStoreReadError.JSONValueModel: removed first‑value/write tracking state; kept a simpler observe/set/reset flow.BrowserPrewarmedWebViewPooland upgrade prewarmers: droppedbrowserWebExtensionHostparameters; updated call sites.Migration
browser.webExtensionskey is no longer read; previously configured extensions will not load.SettingsHostActions.discoverBrowserWebExtensions(),.browserWebExtensionsSupported(), and.browserWebExtensionLoadErrorUpdates().JSONConfigStore.update(_:)calls with explicit read/modify/set within the store actor.browserWebExtensionHostparameters and references; useBrowserPrewarmedWebViewPool.prewarm(url:profileID:)andclaim(url:profileID:websiteDataStore:).Written for commit 6a05257. Summary will update on new commits.
Summary by CodeRabbit