Skip to content

Fix iOS App Store lane bundle fixture #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 2 commits into from
Jul 16, 2026
Merged

Fix iOS App Store lane bundle fixture #8242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
741d4d8
Fix iOS upload bundle fixture metadata
lawrencecchen Jul 16, 2026
811f4a3
Update invalid framework upload regression
lawrencecchen Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions tests/test_ios_appstore_lane_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ def setting(prefix):
write_plist(
app / "Info.plist",
{{
"CFBundleExecutable": "cmux",
"CFBundleIdentifier": bundle_id,
"CFBundleVersion": build_number,
"CFBundleShortVersionString": marketing_version,
Expand All @@ -332,7 +333,7 @@ def setting(prefix):
payload_root = export_path / "Payload"
app = payload_root / "cmux.app"
write_plist(app / "Info.plist", archived_info)
if os.environ.get("CMUX_FAKE_EMBED_FRAMEWORK_WITHOUT_MINIMUM_OS") == "1":
if os.environ.get("CMUX_FAKE_EMBED_INVALID_FRAMEWORK_SHELL") == "1":
write_plist(
app / "Frameworks" / "Iroh.framework" / "Info.plist",
{{
Expand Down Expand Up @@ -509,6 +510,7 @@ def _bump_patch(version: str) -> str:
def _write_fake_archive(path: Path, *, bundle_id: str, build_number: str, marketing_version: str) -> None:
app = path / "Products" / "Applications" / "cmux.app"
info = {
"CFBundleExecutable": "cmux",
"CFBundleIdentifier": bundle_id,
"CFBundleVersion": build_number,
"CFBundleShortVersionString": marketing_version,
Expand Down Expand Up @@ -638,10 +640,10 @@ def test_upload_beta_lane_uses_beta_marketing_version(tmp: Path, fakebin: Path)
)


def test_upload_rejects_framework_without_minimum_os_version(tmp: Path, fakebin: Path) -> None:
def test_upload_strips_framework_without_valid_executable(tmp: Path, fakebin: Path) -> None:
env = _base_env(tmp, fakebin)
env["CMUX_IOS_UPLOAD_DIR"] = str(tmp / "upload")
env["CMUX_FAKE_EMBED_FRAMEWORK_WITHOUT_MINIMUM_OS"] = "1"
env["CMUX_FAKE_EMBED_INVALID_FRAMEWORK_SHELL"] = "1"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore MinimumOSVersion failure coverage

By replacing the old malformed-framework fixture with CMUX_FAKE_EMBED_INVALID_FRAMEWORK_SHELL, this test now covers only the re-sign strip path: the fake framework has no executable, so it is removed before verify_ipa_framework_minimum_os_versions can check MinimumOSVersion. I checked the suite for MinimumOSVersion, and there is no remaining test that embeds a valid dynamic-library framework missing that key, even though ios/scripts/upload-testflight.sh still treats that as a hard pre-upload failure. Please keep this shell-strip regression, but add/retain a separate dynamic-framework fixture for the missing/invalid MinimumOSVersion case so that validation path cannot regress silently.

Useful? React with 👍 / 👎.

result = _run(
[
"bash",
Expand All @@ -656,12 +658,23 @@ def test_upload_rejects_framework_without_minimum_os_version(tmp: Path, fakebin:
],
env=env,
tmp=tmp,
log_failure=False,
)
_check(result.returncode != 0, "upload rejects a framework without MinimumOSVersion")
_check(result.returncode == 0, "upload strips an invalid embedded framework shell")
_check(
"stripping embedded framework without a valid dynamic-library executable "
"(<executable missing>)" in result.stdout,
"upload reports why the invalid framework shell was stripped",
)
ipa_line = next(line for line in result.stdout.splitlines() if line.startswith("IPA_PATH="))
ipa_path = Path(ipa_line.removeprefix("IPA_PATH="))
with zipfile.ZipFile(ipa_path) as zf:
ipa_entries = zf.namelist()
_check(
"Iroh.framework is missing MinimumOSVersion" in result.stderr,
"framework metadata failure names the malformed framework",
not any(
entry.startswith("Payload/cmux.app/Frameworks/Iroh.framework/")
for entry in ipa_entries
),
"final signed IPA omits the stripped framework shell",
)


Expand Down Expand Up @@ -1301,8 +1314,8 @@ def main() -> None:
fakebin = tmp / "bin"
_install_fake_tools(fakebin)
test_upload_beta_lane_uses_beta_marketing_version(tmp / "beta-upload-test", fakebin)
test_upload_rejects_framework_without_minimum_os_version(
tmp / "beta-framework-metadata-test", fakebin
test_upload_strips_framework_without_valid_executable(
tmp / "beta-framework-strip-test", fakebin
)
test_upload_beta_archive_path_accepts_marketing_version_override(tmp / "beta-archive-override-test", fakebin)
test_upload_beta_auto_version_uses_checked_in_beta_floor(tmp / "beta-auto-version-test", fakebin)
Expand Down