Skip to content

Fix iOS deployment target for Iroh framework compatibility #8220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azooz2003-bit merged 1 commit into from
Jul 16, 2026
Merged

Fix iOS deployment target for Iroh framework compatibility #8220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Config/Shared.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ CMUX_CRASH_REPORTING_ENABLED = YES
// ==========================================
// Platform Configuration
// ==========================================
IPHONEOS_DEPLOYMENT_TARGET = 18.4
IPHONEOS_DEPLOYMENT_TARGET = 18.0

@coderabbitai coderabbitai Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Remove or update the stale project-level deployment-target overrides.

ios/cmux-ios.xcodeproj/project.pbxproj still sets IPHONEOS_DEPLOYMENT_TARGET = 18.4 for both Debug and Release, so those explicit settings can override this shared 18.0 value. The effective build target may therefore remain 18.4 and the TestFlight compatibility objective will not be achieved. Update both project configurations to 18.0, or remove the overrides so Shared.xcconfig is authoritative.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ios/Config/Shared.xcconfig` at line 61, Update the Debug and Release
project-level IPHONEOS_DEPLOYMENT_TARGET settings in the Xcode project
configurations to 18.0, or remove those overrides so Shared.xcconfig remains
authoritative and the effective deployment target is 18.0.

@greptile-apps greptile-apps Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Stale deployment target in project.pbxproj not updated

ios/cmux-ios.xcodeproj/project.pbxproj still contains IPHONEOS_DEPLOYMENT_TARGET = 18.4 in the project-level Debug and Release build configurations (lines 350 and 408). These are project-level settings (no baseConfigurationReference), so the target-level xcconfig value of 18.0 correctly wins at build time — the fix works. However, the leftover 18.4 entries create a misleading "Levels" view in Xcode's Build Settings inspector and could confuse developers who check the project setting directly or who later remove the xcconfig reference. Consider updating those two entries in project.pbxproj to 18.0 for consistency.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


// (1 == iPhone, 2 == iPad)
TARGETED_DEVICE_FAMILY = 1,2
Expand Down