Repository navigation
Fix: set IOS_BETA_BUNDLE_ID at job level for provisioning profile selection - #8192
Conversation
… can use it The provisioning profile step runs before the archive step, so it couldn't access the bundle ID to select the correct profile. Move bundle ID and display name to job env so all steps can access them. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe iOS TestFlight upload job now sets job-level environment variables for the internal beta bundle identifier and display name. ChangesiOS TestFlight workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR moves
Confidence Score: 4/5Safe to merge — the provisioning profile selection bug is correctly fixed, and no step behavior changes in an unexpected way. The change correctly exposes the bundle ID at job level so the provisioning step can read it. The only concern is that the archive step still re-declares the same two variables in its own step-level env block, creating a dual source of truth that could silently diverge if one side is updated without the other in a future PR. .github/workflows/ios-testflight.yml — specifically the step-level env block in the Archive, export, and upload to TestFlight step (around line 497) which still redundantly declares the same bundle ID and display name now also set at the job level. Important Files Changed
|
The internal provisioning profile in ASC was created without Push Notifications enabled. Temporarily skip the aps-environment entitlement check for internal builds to unblock the TestFlight upload workflow. The proper fix requires recreating the internal provisioning profile in ASC with Push Notifications enabled. See: manaflow-ai#8192
* TestFlight workflow: prepare for proper internal provisioning profile The internal TestFlight build requires a provisioning profile with push notifications (aps-environment) enabled. Build #7 successfully archived and exported the app but failed during validation: error: re-signed app is still missing aps-environment; refusing to upload a push-broken build This requires creating a valid provisioning profile for dev.cmux.app.internal in App Store Connect with Push Notifications capability enabled, then setting the GitHub secret IOS_BETA_PROVISIONING_PROFILE_INTERNAL_BASE64. See: #8192 * Validate internal TestFlight push entitlement --------- Co-authored-by: cmux reload-cloud <cmux-reload-cloud@users.noreply.github.com> Co-authored-by: lawrencecchen <54008264+lawrencecchen@users.noreply.github.com>
The provisioning profile installation step runs before the archive step, so it couldn't access IOS_BETA_BUNDLE_ID to select the correct profile. This moves the bundle ID and display name to the job-level environment so all steps can access them.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Set IOS_BETA_BUNDLE_ID and IOS_BETA_DISPLAY_NAME at the job level in the iOS TestFlight workflow so the provisioning profile step can select the correct profile for internal builds. Fixes profile selection failing when the archive step defines these values too late.
Written for commit f5c4c23. Summary will update on new commits.
Summary by CodeRabbit