Repository navigation
Restore native docs channel picker and fix deploy - #8172
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe docs version picker now uses a native select for release and nightly channels, navigates on channel changes, and renders after sidebar navigation. The reusable docs deployment workflow also updates its pinned Bun setup action revision. ChangesDocs version picker
Docs deployment workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR restores the docs release/nightly channel selector to its intended position below the nav (Changelog) by moving
Confidence Score: 4/5Safe to merge; changes are a straightforward UI reorder, a native element replacement, and a CI pin update with no logic-critical paths affected. All three changes are narrow and well-scoped. The workflow fix is a SHA-pinned action update. The sidebar reorder is purely positional. The version picker replacement swaps a composite component for a native element and introduces only a minor redundant accessible-name annotation. web/app/[locale]/components/docs-version-picker.tsx — minor accessible-name duplication worth cleaning up. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant User
participant DocsSidebar
participant DocsVersionPicker as DocsVersionPicker (native select)
participant window.location
User->>DocsSidebar: opens docs page
DocsSidebar->>DocsSidebar: renders DocsSearch + nav items
DocsSidebar->>DocsVersionPicker: renders at bottom (after Changelog)
User->>DocsVersionPicker: changes channel (release ↔ nightly)
DocsVersionPicker->>window.location: assign(docsChannelUrl(value, pathname, search, hash))
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant User
participant DocsSidebar
participant DocsVersionPicker as DocsVersionPicker (native select)
participant window.location
User->>DocsSidebar: opens docs page
DocsSidebar->>DocsSidebar: renders DocsSearch + nav items
DocsSidebar->>DocsVersionPicker: renders at bottom (after Changelog)
User->>DocsVersionPicker: changes channel (release ↔ nightly)
DocsVersionPicker->>window.location: assign(docsChannelUrl(value, pathname, search, hash))
Reviews (1): Last reviewed commit: "Move native docs picker below navigation" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <label className="block px-3 pt-4 pb-4" data-pagefind-ignore="all"> | ||
| <span className="sr-only">{label}</span> | ||
| <select | ||
| aria-label={label} |
There was a problem hiding this comment.
<label> wraps the <select>, so the <span className="sr-only"> text already becomes the select's accessible name through the label association. The explicit aria-label attribute on the <select> takes priority over that programmatic label (per ARIA spec), which makes the <span> a dead node for screen readers. Either the <span> or the aria-label should be removed to keep the accessible name in one place.
| <label className="block px-3 pt-4 pb-4" data-pagefind-ignore="all"> | |
| <span className="sr-only">{label}</span> | |
| <select | |
| aria-label={label} | |
| <label className="block px-3 pt-4 pb-4" data-pagefind-ignore="all"> | |
| <span className="sr-only">{label}</span> | |
| <select |
1 participant
Summary
setup-bunaction pin in docs deployment CITesting
bun test tests/docs-channel.test.ts tests/docs-search-index.test.ts tests/docs-search-utils.test.ts tests/client-config-env.test.tsbun run typecheckactionlint .github/workflows/docs-deploy-reusable.yml/docs/base: native selector follows Changelogoven-sh/setup-bun@0c5077e...existsFailure fixed
https://github.com/manaflow-ai/cmux/actions/runs/29411036747
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Restores the native release/nightly docs channel picker and places it below the Changelog in the sidebar. Also fixes the docs deploy by pinning the Bun setup action to a stable v2.
Refactors
@base-ui-components/react/selectwith a native<select>and moved the picker below the Changelog.Bug Fixes
oven-sh/setup-bunto v2 in the docs deploy workflow to resolve CI failures.Written for commit ebb8601. Summary will update on new commits.
Summary by CodeRabbit
Accessibility & Usability
Maintenance